implicit declaration of function set_irq_chip_and_handler

2 messages, 2 authors, 2006-10-18 · open the first message on its own page

implicit declaration of function set_irq_chip_and_handler

From: Olaf Hering <hidden>
Date: 2006-10-18 08:04:57

Current Linus tree has two new warnings

arch/powerpc/kernel/irq.c: In function irq_dispose_mapping:
arch/powerpc/kernel/irq.c:642: warning: implicit declaration of function set_irq_chip_and_handler
arch/powerpc/sysdev/mpic.c: In function mpic_host_map:
arch/powerpc/sysdev/mpic.c:770: warning: implicit declaration of function set_irq_chip_and_handler

It links anyway for some reason.
There is no prototype anymore, but still many users.

a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
 [PATCH] genirq: clean up irq-flow-type naming

[patch] genirq: clean up irq-flow-type naming, fix

From: Ingo Molnar <hidden>
Date: 2006-10-18 08:25:21

* Olaf Hering [off-list ref] wrote:
There is no prototype anymore, but still many users.

a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
 [PATCH] genirq: clean up irq-flow-type naming
oops, that was unintended. The patch below should fix this.

	Ingo

--------------->
Subject: genirq: clean up irq-flow-type naming, fix
From: Ingo Molnar <redacted>

re-add the set_irq_chip_and_handler() prototype, it's still widely used.

Signed-off-by: Ingo Molnar <redacted>
---
 include/linux/irq.h |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/include/linux/irq.h
===================================================================
--- linux.orig/include/linux/irq.h
+++ linux/include/linux/irq.h
@@ -322,6 +322,9 @@ extern struct irq_chip no_irq_chip;
 extern struct irq_chip dummy_irq_chip;
 
 extern void
+set_irq_chip_and_handler(unsigned int irq, struct irq_chip *chip,
+			 irq_flow_handler_t handle);
+extern void
 set_irq_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 			      irq_flow_handler_t handle, const char *name);
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help