RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl

After applying these patches, it seems the kernel leaks memory.
No doubt you forget to call simple_attr_close on "[PATCH 09/14]
spufs: add support for read/write oncntl".

Signed-off-by: Masato Noguchi <redacted>

---

Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c

+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c

@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode=20

=20
 static struct file_operations spufs_cntl_fops =3D {
 	.open =3D spufs_cntl_open,
+	.close =3D simple_attr_close,
 	.read =3D simple_attr_read,
 	.write =3D simple_attr_write,
 	.mmap =3D spufs_cntl_mmap,

On Tuesday 10 October 2006 08:00, Noguchi, Masato wrote:

After applying these patches, it seems the kernel leaks memory.
No doubt you forget to call simple_attr_close on "[PATCH 09/14]
spufs: add support for read/write oncntl".

Ok, thanks for pointing this out.
 

Signed-off-by: Masato Noguchi <redacted>

Signed-off-by: Arnd Bergmann <redacted>

Paul, please apply.

	Arnd <><