[PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()

STALE7285d

2 messages, 2 authors, 2006-08-22 · open the first message on its own page

[PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()

From: Alexey Dobriyan <hidden>
Date: 2006-08-21 23:22:42

Signed-off-by: Alexey Dobriyan <redacted>
---

 drivers/macintosh/windfarm_smu_sat.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -397,12 +397,7 @@ static int wf_sat_detach(struct i2c_clie
 
 static int __init sat_sensors_init(void)
 {
-	int err;
-
-	err = i2c_add_driver(&wf_sat_driver);
-	if (err < 0)
-		return err;
-	return 0;
+	return i2c_add_driver(&wf_sat_driver);
 }
 
 static void __exit sat_sensors_exit(void)

Re: [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-08-22 03:27:25

On Tue, 2006-08-22 at 03:22 +0400, Alexey Dobriyan wrote:
Signed-off-by: Alexey Dobriyan <redacted>
Oops ... :)

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
quoted hunk
---

 drivers/macintosh/windfarm_smu_sat.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -397,12 +397,7 @@ static int wf_sat_detach(struct i2c_clie
 
 static int __init sat_sensors_init(void)
 {
-	int err;
-
-	err = i2c_add_driver(&wf_sat_driver);
-	if (err < 0)
-		return err;
-	return 0;
+	return i2c_add_driver(&wf_sat_driver);
 }
 
 static void __exit sat_sensors_exit(void)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help