From: Jon Loeliger <hidden> Date: 2006-08-17 17:30:31
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <redacted>
Signed-off-by: Jon Loeliger <redacted>
---
Paul,
If possible, this should be slated for the
upcoming .18 release.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Doesn't the device tree compiler add linux,phandle properties as needed?
In this case that would be when the node is referenced by a
"<&/foo/bar/i8259@4d0>" property.
On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
quoted hunk
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <redacted>
Signed-off-by: Jon Loeliger <redacted>
---
Paul,
If possible, this should be slated for the
upcoming .18 release.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
From: Jon Loeliger <hidden> Date: 2006-08-17 21:25:56
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Signed-off-by: Jon Loeliger <redacted>
---
On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
Doesn't the device tree compiler add linux,phandle properties as needed?
In this case that would be when the node is referenced by a
"<&/foo/bar/i8259@4d0>" property.
On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
quoted
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <redacted>
Signed-off-by: Jon Loeliger <redacted>
---
Paul,
If you think this is better, please apply this patch
instead of my previous patch with the subject line:
Patch] Fix the mpc8641_hpcn.dts file.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 121 ++++++++++++++++----------------
1 files changed, 60 insertions(+), 61 deletions(-)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2006-08-18 00:09:38
On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Not 100% sure here but can't we use a label and do &label rather than
having to copy the full path every time ? Would make things easier :) If
not, that's probably something to add to dtc...
Cheers,
Ben.
quoted hunk
Signed-off-by: Jon Loeliger <redacted>
---
On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
quoted
Doesn't the device tree compiler add linux,phandle properties as needed?
In this case that would be when the node is referenced by a
"<&/foo/bar/i8259@4d0>" property.
On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
quoted
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <redacted>
Signed-off-by: Jon Loeliger <redacted>
---
Paul,
If you think this is better, please apply this patch
instead of my previous patch with the subject line:
Patch] Fix the mpc8641_hpcn.dts file.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 121 ++++++++++++++++----------------
1 files changed, 60 insertions(+), 61 deletions(-)
From: Mark A. Greer <hidden> Date: 2006-08-18 00:38:56
On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin Herrenschmidt wrote:
On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
quoted
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Not 100% sure here but can't we use a label and do &label rather than
having to copy the full path every time ? Would make things easier :) If
not, that's probably something to add to dtc...
Isn't linux,phandle basically the label that you speak of, though?
IOW, you may be saying, "No, keep using the linux,phandle".
Just trying to clarify things although I'm not sure that I really am... :)
Mark
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2006-08-18 02:00:05
On Thu, 2006-08-17 at 17:43 -0700, Mark A. Greer wrote:
On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin Herrenschmidt wrote:
quoted
On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
quoted
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Not 100% sure here but can't we use a label and do &label rather than
having to copy the full path every time ? Would make things easier :) If
not, that's probably something to add to dtc...
Isn't linux,phandle basically the label that you speak of, though?
IOW, you may be saying, "No, keep using the linux,phandle".
No, more something like
pic:
<pic_node>
and later
&pic
Just trying to clarify things although I'm not sure that I really am... :)
Mark
Is it a good idea? Why we can not endure the "linux,phandle =3D <4d0>" =
in
i8259 node? And besides, this node was already referenced by the other
entries.
Using "&/soc8641@f8000000/pci@8000/i8259@4d0" or label seems so verbose
and weird.
-----Original Message-----
From: linuxppc-dev-bounces+wei.zhang=3Dfreescale.com@ozlabs.org=20
[mailto:linuxppc-dev-bounces+wei.zhang=3Dfreescale.com@ozlabs.or
g] On Behalf Of Benjamin Herrenschmidt
Sent: Friday, August 18, 2006 10:00 AM
To: Mark A. Greer
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Directly reference i8259@4d0 nodes in=20
mpc8641_hpcn.dts.
=20
On Thu, 2006-08-17 at 17:43 -0700, Mark A. Greer wrote:
quoted
On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin=20
Herrenschmidt wrote:
quoted
quoted
On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
quoted
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
=20
Not 100% sure here but can't we use a label and do &label=20
rather than
quoted
quoted
having to copy the full path every time ? Would make=20
things easier :) If
quoted
quoted
not, that's probably something to add to dtc...
=20
Isn't linux,phandle basically the label that you speak of, though?
IOW, you may be saying, "No, keep using the linux,phandle".
=20
No, more something like
=20
pic:
<pic_node>
=20
and later
=20
&pic
=20
quoted
Just trying to clarify things although I'm not sure that I=20
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2006-08-18 07:22:10
On Fri, 2006-08-18 at 13:54 +0800, Zhang Wei-r63237 wrote:
Is it a good idea? Why we can not endure the "linux,phandle = <4d0>" in
i8259 node? And besides, this node was already referenced by the other
entries.
Because magic numbers are evil and nice names are better ? :)
Using "&/soc8641@f8000000/pci@8000/i8259@4d0" or label seems so verbose
and weird.
From: Jon Loeliger <hidden> Date: 2006-08-18 17:38:46
On Thu, 2006-08-17 at 16:20, Jon Loeliger wrote:
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Signed-off-by: Jon Loeliger <redacted>
---
On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
quoted
Doesn't the device tree compiler add linux,phandle properties as needed?
In this case that would be when the node is referenced by a
"<&/foo/bar/i8259@4d0>" property.
On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
quoted
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <redacted>
Signed-off-by: Jon Loeliger <redacted>
---
Paul,
If you think this is better, please apply this patch
instead of my previous patch with the subject line:
Patch] Fix the mpc8641_hpcn.dts file.
Thanks,
jdl
Paul,
I'll take the application of the original patch,
Fix the mpc8641_hpcn.dts file.
as an indication that this, alternate version should
now be simply dropped!
Thanks,
jdl