[PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()

STALE7329d

4 messages, 2 authors, 2006-07-09 · open the first message on its own page

[PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()

From: Haren Myneni <haren@us.ibm.com>
Date: 2006-07-09 01:29:08

If OK, please sent this patch to upstream.

Thanks
Haren

When invoked kdump boot, plpar_eoi() call is getting failed and calling 
panic().
Kernel panic - not syncing: bad return code EOI - rc = -4, value=ff000000

The issue is with the desc->chip->eoi(XICS_IPI) in xics_teardown_cpu(). 
Instead of passing the virq to desc->chip->eoi(), XICS_IPI is used. 
Also, clear IPI in xics_teardown_cpu() got removed recently (in 
2.6.17-git25).  Noticed in some crash dump cases (Ex: initiate kdump 
boot using soft-reset and xmon is enabled), IPI is not cleared for some 
CPU(s) before starting the kdump boot. Hence, causing the kdump boot 
failure.

Signed-off-by: Haren Myneni <haren@us.ibm.com>


 

Re: [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-07-09 01:37:16

On Sat, 2006-07-08 at 18:28 -0700, Haren Myneni wrote:
If OK, please sent this patch to upstream.

Thanks
Haren

When invoked kdump boot, plpar_eoi() call is getting failed and calling 
panic().
Kernel panic - not syncing: bad return code EOI - rc = -4, value=ff000000

The issue is with the desc->chip->eoi(XICS_IPI) in xics_teardown_cpu(). 
Instead of passing the virq to desc->chip->eoi(), XICS_IPI is used. 
Also, clear IPI in xics_teardown_cpu() got removed recently (in 
2.6.17-git25).  Noticed in some crash dump cases (Ex: initiate kdump 
boot using soft-reset and xmon is enabled), IPI is not cleared for some 
CPU(s) before starting the kdump boot. Hence, causing the kdump boot 
failure.
It's already fixed in my latest patch that fixes some issues with the
new irq rework. Hopefully, paul will send the patch upstream tomorrow
after we had a chance to test it a bit more.

Cheers,
Ben

Re: [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()

From: Haren Myneni <haren@us.ibm.com>
Date: 2006-07-09 02:18:16

Benjamin Herrenschmidt wrote:
On Sat, 2006-07-08 at 18:28 -0700, Haren Myneni wrote:
 
quoted
If OK, please sent this patch to upstream.

Thanks
Haren

When invoked kdump boot, plpar_eoi() call is getting failed and calling 
panic().
Kernel panic - not syncing: bad return code EOI - rc = -4, value=ff000000

The issue is with the desc->chip->eoi(XICS_IPI) in xics_teardown_cpu(). 
Instead of passing the virq to desc->chip->eoi(), XICS_IPI is used. 
Also, clear IPI in xics_teardown_cpu() got removed recently (in 
2.6.17-git25).  Noticed in some crash dump cases (Ex: initiate kdump 
boot using soft-reset and xmon is enabled), IPI is not cleared for some 
CPU(s) before starting the kdump boot. Hence, causing the kdump boot 
failure.
   
It's already fixed in my latest patch that fixes some issues with the
new irq rework. Hopefully, paul will send the patch upstream tomorrow
after we had a chance to test it a bit more.

Cheers,
Ben

 
Ok, Are you talking about the patch posted 
http://ozlabs.org/pipermail/linuxppc-dev/2006-July/024350.html? Sorry, I 
did not notice it before I posted. Yes, it is fixed passing proper ipi 
value to desc->chip->eoi(). But, we also to need to clear IPI  in 
xics_teardown_cpu(). 
 
Thanks
Haren



Re: [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2006-07-09 04:08:56

Ok, Are you talking about the patch posted 
http://ozlabs.org/pipermail/linuxppc-dev/2006-July/024350.html? Sorry, I 
did not notice it before I posted. Yes, it is fixed passing proper ipi 
value to desc->chip->eoi(). But, we also to need to clear IPI  in 
xics_teardown_cpu(). 
Ok, I'll fix that too.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help