RE: [PATCH 1/7] powerpc: Add mpc8360epb platform support

-----Original Message-----
From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]
Sent: Saturday, July 01, 2006 5:00 PM
To: Li Yang-r58472
Cc: 'Vitaly Bordug'; 'Paul Mackerras'; linuxppc-dev@ozlabs.org; Phillips
Kim-R1AAHA; Chu hanjin-r52514; Yin Olivia-r63875;
'linux-kernel@vger.kernel.org'
Subject: RE: [PATCH 1/7] powerpc: Add mpc8360epb platform support

On Fri, 2006-06-30 at 18:27 +0800, Li Yang-r58472 wrote:

quoted

quoted

-----Original Message-----
From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]
Sent: Thursday, June 29, 2006 12:59 AM
To: Li Yang-r58472
Cc: 'Paul Mackerras'; linuxppc-dev@ozlabs.org; Phillips Kim-R1AAHA; Chu
hanjin-r52514; Yin Olivia-r63875; 'linux-kernel@vger.kernel.org'
Subject: Re: [PATCH 1/7] powerpc: Add mpc8360epb platform support

On Wed, 28 Jun 2006 22:23:03 +0800
Li Yang-r58472 [off-list ref] wrote:

[snip]

quoted

quoted

 config MPC834x

@@ -24,4 +31,10 @@ config MPC834x
 	select PPC_INDIRECT_PCI
 	default y if MPC834x_SYS

+config MPC836x
+	bool
+	select PPC_UDBG_16550

debug option made default?

I'm afraid this is needed to boot.  83xx family platforms need it to

initialize early console.  And it does appear in several defconfigs of other
platforms.

How so ? Why would having a serial console be mandatory ? Embedded might
want to boot without a console and use the serial port for other things.
This should be left as a config option (though you are welcome to put it
in the defconfig for your platform)

The problem is that we don't have this PPC_UBDG_16550 option configurable now, and it is only made by default for several boards including pseries, chrp, prep, cell, and all 83xx and 85xx platforms.  If we need to change the whole thing, how should we do it?

quoted

quoted

quoted

+	select PPC_INDIRECT_PCI
+	default y if MPC8360E_PB
+
 endmenu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

The problem is that we don't have this PPC_UBDG_16550 option configurable now,
and it is only made by default for several boards including pseries, chrp, prep, cell,
and all 83xx and 85xx platforms.  If we need to change the whole thing, how should we do it?

It's up to your platformn code to enable it though. udbg will only kick
in from the legacy serial console code if your firmware indicates that
stdout is on a serial port. If the firmware doesn't, udbg won't kick in.
But yeah, build it in by default if you want then.

Ben.