Re: [PATCH 5/6] CPM_UART: unify clock sources

2 messages, 2 authors, 2006-06-24 · open the first message on its own page

Re: [PATCH 5/6] CPM_UART: unify clock sources

From: Jon Loeliger <hidden>
Date: 2006-06-24 16:22:17

So, like, the other day Vitaly Bordug mumbled:
That was my first guess as well, but: 
The aim is yet moving to powerpc not to break existing ppc/ stuff. 
So if alternatively platform_data may be utilized, all relevant ppc
stuff that uses cpm uart should be updated. While doing the driver
"platformize" trick, I made it possible to keep legacy behaviour
(pd-less), this is not going to afford such a thing. 

IOW, I don't see much sense in updating ppc/ BSP files, just to keep
the right way. It does not look very neat now, but does the job of
moving FW and keeping existing stuff sane. If there is better approach
envisioned, I'll definitely follow..
And don't forget that the subsequent, follow-up patches
will be to _remove_ the 85xx family from arch/ppc as well.
The trick right now is simply to get it working in arch/powerpc
so that we can move forward there.  Worrying about absolute
cleanliness in arch/ppc for 85xx shouldn't, in my opinion,
be the highest concern.

Thanks,
jdl

Re: [PATCH 5/6] CPM_UART: unify clock sources

From: Kumar Gala <hidden>
Date: 2006-06-24 16:27:36

On Jun 24, 2006, at 11:22 AM, Jon Loeliger wrote:
So, like, the other day Vitaly Bordug mumbled:
quoted
That was my first guess as well, but:
The aim is yet moving to powerpc not to break existing ppc/ stuff.
So if alternatively platform_data may be utilized, all relevant ppc
stuff that uses cpm uart should be updated. While doing the driver
"platformize" trick, I made it possible to keep legacy behaviour
(pd-less), this is not going to afford such a thing.

IOW, I don't see much sense in updating ppc/ BSP files, just to keep
the right way. It does not look very neat now, but does the job of
moving FW and keeping existing stuff sane. If there is better  
approach
envisioned, I'll definitely follow..
And don't forget that the subsequent, follow-up patches
will be to _remove_ the 85xx family from arch/ppc as well.
The trick right now is simply to get it working in arch/powerpc
so that we can move forward there.  Worrying about absolute
cleanliness in arch/ppc for 85xx shouldn't, in my opinion,
be the highest concern.
Its a concern until we have a way of booting existing 85xx systems w/ 
their boot loaders using arch/powerpc kernels.

Also, CPM effects more than just 85xx so care needs to be taken for  
8xx & 82xx.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help