Re: [PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR.

So, like, the other day Benjamin Herrenschmidt mumbled:

On Thu, 2006-06-08 at 16:58 -0500, Jon Loeliger wrote:

quoted

Signed-off-by: Jon Loeliger <redacted>

Beware about this one... the CPU setup code might run before the feature
fixup in the future...
...
or go read the feature bit directly in the structure
rather than relying on the fixup mecanism.

OK.

you should probably do a separate setup function for your core

Truth be told, this is a pretty generic fix for other
parts as well. If I recall correctly, 7447, 7448, 7448A and 7450
as well as the new 8641 now.

But I can certainly introduce a new setup function here
if you think that is the right thing to do.  No problem.

Thanks,
jdl

quoted

--- a/arch/powerpc/kernel/cpu_setup_6xx.S
+++ b/arch/powerpc/kernel/cpu_setup_6xx.S

quoted

+BEGIN_FTR_SECTION
 	mfspr	r11,SPRN_L3CR
 	andis.	r11,r11,L3CR_L3E@h
 	beq	1f
+END_FTR_SECTION_IFSET(CPU_FTR_L3CR)
 	lwz	r6,CPU_SPEC_FEATURES(r5)
 	andi.	r0,r6,CPU_FTR_L3_DISABLE_NAP
 	beq	1f

On Fri, 2006-06-09 at 11:00 -0500, Jon Loeliger wrote:

So, like, the other day Benjamin Herrenschmidt mumbled:

quoted

On Thu, 2006-06-08 at 16:58 -0500, Jon Loeliger wrote:

quoted

Signed-off-by: Jon Loeliger <redacted>

Beware about this one... the CPU setup code might run before the feature
fixup in the future...
...
or go read the feature bit directly in the structure
rather than relying on the fixup mecanism.

OK.

quoted

you should probably do a separate setup function for your core

Truth be told, this is a pretty generic fix for other
parts as well. If I recall correctly, 7447, 7448, 7448A and 7450
as well as the new 8641 now.

But I can certainly introduce a new setup function here
if you think that is the right thing to do.  No problem.

No, go for the generic fix.

Ben.