Minor bug in file irq.h

Hello,

I use a Linux 2.6.9 on MPC85xx.

In the ./linux/include/asm-ppc/irq.h file, I encountered a problem with the
timer3 interrupt definition :
#define     SIU_INT_TIMER3          ((uint)0x0e+CPM_IRQ_OFFSET)

This definition generates a compilation error  because is interpreted as
something like
((uint)0x0(e+CPM_IRQ_OFFSET)) ie 0x0 exponent  + CPM_IRQ_OFFSET.

To work around just parenthesis or add a space character between 'e' and '+'
#define     SIU_INT_TIMER3          ((uint)0x0e +CPM_IRQ_OFFSET)

Laurent

On Feb 28, 2006, at 2:50 AM, Laurent Lagrange wrote:

Hello,

I use a Linux 2.6.9 on MPC85xx.

In the ./linux/include/asm-ppc/irq.h file, I encountered a problem  
with the
timer3 interrupt definition :
#define     SIU_INT_TIMER3          ((uint)0x0e+CPM_IRQ_OFFSET)

This definition generates a compilation error  because is  
interpreted as
something like
((uint)0x0(e+CPM_IRQ_OFFSET)) ie 0x0 exponent  + CPM_IRQ_OFFSET.

To work around just parenthesis or add a space character between  
'e' and '+'
#define     SIU_INT_TIMER3          ((uint)0x0e +CPM_IRQ_OFFSET)

Do you mind providing this in patch form with a signed-off-by.  I'll  
include it in the queue of 85xx related patches.

- kumar

Hello,

Here is a patch for the 2 bugs in irq.h.

This is the first time, I generate a patch.
I don't know if this is the right method.

Best regards
Laurent

In the ./linux/include/asm-ppc/irq.h file, I encountered a problem with

the

timer3 interrupt definition :
#define     SIU_INT_TIMER3          ((uint)0x0e+CPM_IRQ_OFFSET)

This definition generates a compilation error  because is interpreted as

Note that this is not the only such definition. At least this one  is
critical, too:

	#define SIU_INT_PC1             ((uint)0x3e+CPM_IRQ_OFFSET)

Best regards,

Wolfgang Denk

-----Message d'origine-----
De : Kumar Gala [mailto:galak@kernel.crashing.org]
Envoye : mar. 28 fevrier 2006 15:38
A : Laurent Lagrange
Cc : linuxppc-embedded@ozlabs.org
Objet : Re: Minor bug in file irq.h



On Feb 28, 2006, at 2:50 AM, Laurent Lagrange wrote:

quoted

Hello,

I use a Linux 2.6.9 on MPC85xx.

In the ./linux/include/asm-ppc/irq.h file, I encountered a problem
with the
timer3 interrupt definition :
#define     SIU_INT_TIMER3          ((uint)0x0e+CPM_IRQ_OFFSET)

This definition generates a compilation error  because is
interpreted as
something like
((uint)0x0(e+CPM_IRQ_OFFSET)) ie 0x0 exponent  + CPM_IRQ_OFFSET.

To work around just parenthesis or add a space character between
'e' and '+'
#define     SIU_INT_TIMER3          ((uint)0x0e +CPM_IRQ_OFFSET)

Do you mind providing this in patch form with a signed-off-by.  I'll
include it in the queue of 85xx related patches.

- kumar

Hello,

I would want to use a linux kernel 2.6 on a custom MPC8xx board.
Which stable kernel release must or can I use ?

Thanks
Laurent

Hello,

I use a Linux 2.6.x on a custom 8270 board with a RTC on the I2C bus
(rtc8564).
I want to use it as the system date :
	- Is it possible ?
	- Do I need to initialize the "ppc_md" structure in the "platform_init"
function with my own RTC functions ?
	- In that case, can I use the kernel I2C layer ?

Thanks all
Laurent

Laurent,

attached you find a rtc-driver for 2.6.13.
I ported it from 2.4 myself, because i didnt find any 2.6-port out in the 
world.
the ppc_md-structure entries are initialized within the driver itself. This is 
propably not 100% consistent with the coding conventions, but it works fro 
me.
This i2c-layer can still be used with this driver; i have a LM75 and an EEPROM 
on the same bus, which i operate via LM-Sensors and the i2c-dev driver.

-- 
Mit freundlichen Gruessen / Best regards

Claus Gindhart
SW R&D 
Kontron Modular Computers
phone :++49 (0)8341-803-374
mailto:claus.gindhart@kontron-modular.com 
http://www.kontron.com

-----BEGIN GEEK CODE BLOCK-----
  Version: 3.1
  GU d- s++:>++:+ a+ C++$ !U !P L++>$ E-- W+(-) N- o? 
  K? w !O !M V !PS PE- Y+ PGP+ t 5? X R* tv- b+ DI+++ 
  D-- G e++> h--- !r x+++
------END GEEK CODE BLOCK------



Am Friday 07 April 2006 10:16 schrieb Laurent Lagrange:
Hello,

I use a Linux 2.6.x on a custom 8270 board with a RTC on the I2C bus
(rtc8564).
I want to use it as the system date :
	- Is it possible ?
	- Do I need to initialize the "ppc_md" structure in the "platform_init"
function with my own RTC functions ?
	- In that case, can I use the kernel I2C layer ?

Thanks all
Laurent


_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

On Fri, Apr 07, 2006 at 10:57:25AM +0200, Claus Gindhart wrote:

Laurent,

attached you find a rtc-driver for 2.6.13.
I ported it from 2.4 myself, because i didnt find any 2.6-port out in the 
world.
the ppc_md-structure entries are initialized within the driver itself. This is 
propably not 100% consistent with the coding conventions, but it works fro 
me.
This i2c-layer can still be used with this driver; i have a LM75 and an EEPROM 
on the same bus, which i operate via LM-Sensors and the i2c-dev driver.

Note that there is a drivers/rtc directory that new (and old) rtc drivers
should be ported to.

Mark