arch/ppc/82xx_io/uart.c bug found

3 messages, 2 authors, 2006-02-20 · open the first message on its own page

arch/ppc/82xx_io/uart.c bug found

From: Wojciech Kromer <hidden>
Date: 2006-02-13 14:16:34

here is orignal uart.c

#ifdef SCC_CONSOLE
                                switch (state->smc_scc_num) {
                                case 0:
                                        page = CPM_CR_SCC1_PAGE;
                                        sblock = CPM_CR_SCC1_SBLOCK;
                                        break;
                                case 1:
                                        page = CPM_CR_SCC2_PAGE;
                                        sblock = CPM_CR_SCC2_SBLOCK;
                                        break;
                                case 2:
                                        page = CPM_CR_SCC3_PAGE;
                                        sblock = CPM_CR_SCC3_SBLOCK;
                                        break;
                                }
....


 so SCC4 is unusable, here is missing code:

                                case 3:
                                        page = CPM_CR_SCC4_PAGE;
                                        sblock = CPM_CR_SCC4_SBLOCK;
                                        break;
                                }

Re: arch/ppc/82xx_io/uart.c bug found

From: Dan Malek <hidden>
Date: 2006-02-13 16:14:30

On Feb 13, 2006, at 8:51 AM, Wojciech Kromer wrote:
here is orignal uart.c
Three things....

One, this code is obsolete and isn't used any more.
Two, it's not a bug, just a feature enhancement.
Three, if you want us to actually do something about
this I need a real patch against an up to date
public source tree and indication it was actually
tested on some platform.

Thanks.

	-- Dan

Re: arch/ppc/82xx_io/uart.c bug found

From: Wojciech Kromer <hidden>
Date: 2006-02-20 07:57:28

Three things....

One, this code is obsolete and isn't used any more.
 
It's in latest linuxppc_2_4_devel from denx.de CVS.
Two, it's not a bug, just a feature enhancement.
 
OK.
Three, if you want us to actually do something about
this I need a real patch against an up to date
public source tree and indication it was actually
tested on some platform.
 
I'm currently using CVS version from denx.de,
there are lot of features I'm using.

Just use this info as an information, not offcial bug note.
I spend few days finding it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help