[PATCH] Don't check pointer for NULL before passing it to kfree [arch/powerpc/kernel/rtas_flash.c]
From: Jesper Juhl <hidden>
Date: 2006-02-04 19:35:53
Also in:
lkml
Checking a pointer for NULL before passing it to kfree is pointless, kfree does its own NULL checking of input. Signed-off-by: Jesper Juhl <redacted> --- arch/powerpc/kernel/rtas_flash.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.16-rc2-git1-orig/arch/powerpc/kernel/rtas_flash.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc2-git1/arch/powerpc/kernel/rtas_flash.c 2006-02-04 20:30:21.000000000 +0100@@ -672,8 +672,7 @@ static void rtas_flash_firmware(int rebo static void remove_flash_pde(struct proc_dir_entry *dp) { if (dp) { - if (dp->data != NULL) - kfree(dp->data); + kfree(dp->data); dp->owner = NULL; remove_proc_entry(dp->name, dp->parent); }