RE: [patch 10/44] generic fls64()

From: Akinobu Mita
Sent: Wednesday, February 01, 2006 03:03
+static inline int fls64(__u64 x)
+{
+	__u32 h =3D x >> 32;
+	if (h)
+		return fls(x) + 32;

Shouldn't this be return fls(h) + 32; ??
                            ^^^

+	return fls(x);
+}
+
+#endif /* _ASM_GENERIC_BITOPS_FLS64_H_ */
=20
--
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
=20
=20

Noticed by Rune Torgersen.

fix generic_fls64().
tcp_cubic is using fls64().

Signed-off-by: Akinobu Mita <redacted>

 include/linux/bitops.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: 2.6-git/include/linux/bitops.h
===================================================================

--- 2.6-git.orig/include/linux/bitops.h
+++ 2.6-git/include/linux/bitops.h

@@ -81,7 +81,7 @@ static inline int generic_fls64(__u64 x)
 {
 	__u32 h = x >> 32;
 	if (h)
-		return fls(x) + 32;
+		return fls(h) + 32;
 	return fls(x);
 }