8260 ethernet driver multicast problem

Hi,
I was encountering a problem with the receipt of multicast packets from eth
interface in 8260 platform. The issue was traced to the fcc_enet.c driver. A
stray return in the set_multicast_list function was the culprit.

The following is the changes that I have made-

Index: fcc_enet.c

@@ -1488,7 +1488,6 @@

     cep = (struct fcc_enet_private *)dev->priv;

-return;
     /* Get pointer to FCC area in parameter RAM.
     */
     ep = (fcc_enet_t *)dev->base_addr;

Can you please tell me whether there is any issue with setting the driver in
multicast or promiscous mode. Was this change deliberately done or is it
really a bug?

Thanks in advance,
Robin

Robin Mathew wrote:

Robin, what's the kernel version you're using?

If you're using 2.6 there's a brand new driver you can use.

Regards

Pantelis

On Dec 14, 2005, at 09:20, Pantelis Antoniou wrote:

Robin Mathew wrote:

quoted

Hi,
I was encountering a problem with the receipt of multicast packets from eth
interface in 8260 platform. The issue was traced to the fcc_enet.c driver. A
stray return in the set_multicast_list function was the culprit.
The following is the changes that I have made-
Index: fcc_enet.c

@@ -1488,7 +1488,6 @@
     cep = (struct fcc_enet_private *)dev->priv;
-return;
     /* Get pointer to FCC area in parameter RAM.
     */
     ep = (fcc_enet_t *)dev->base_addr;

Can you please tell me whether there is any issue with setting the driver in
multicast or promiscous mode. Was this change deliberately done or is it
really a bug?
Thanks in advance,
Robin

Robin, what's the kernel version you're using?

If you're using 2.6 there's a brand new driver you can use.

Has 8260 platform support been pushed out yet?

Andy Fleming wrote:

On Dec 14, 2005, at 09:20, Pantelis Antoniou wrote:

quoted

Robin Mathew wrote:

quoted

Hi,
I was encountering a problem with the receipt of multicast packets from eth
interface in 8260 platform. The issue was traced to the fcc_enet.c driver. A
stray return in the set_multicast_list function was the culprit.
The following is the changes that I have made-
Index: fcc_enet.c

@@ -1488,7 +1488,6 @@
     cep = (struct fcc_enet_private *)dev->priv;
-return;
     /* Get pointer to FCC area in parameter RAM.
     */
     ep = (fcc_enet_t *)dev->base_addr;

Can you please tell me whether there is any issue with setting the driver in
multicast or promiscous mode. Was this change deliberately done or is it
really a bug?
Thanks in advance,
Robin

Robin, what's the kernel version you're using?

If you're using 2.6 there's a brand new driver you can use.

Has 8260 platform support been pushed out yet?

Guess it's not in the stock so far (And I have to update ppc_sys to make the things right), but patches are available here in the list archives.

_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

-- 
Sincerely, Vitaly