[PATCH] powerpc: Call find_legacy_serial_ports() if we enable CONFIG_SERIAL_8250

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE7604d

3 messages, 3 authors, 2005-12-21 · open the first message on its own page

[PATCH] powerpc: Call find_legacy_serial_ports() if we enable CONFIG_SERIAL_8250

From: Kumar Gala <hidden>
Date: 2005-12-21 02:45:27

In setup_arch and setup_system call find_legacy_serial_ports() if we
build in support for 8250 serial ports instead of basing it on PPC_MULTIPLATFORM.

Signed-off-by: Kumar Gala <redacted>

---
commit 399e10aa1c6a3ca64e8e8e8cea7289e9908cc62c
tree 3e5320b8a97a37c4d010186aabf8a95e5be264b4
parent 7b69a37a4e811e72e82896ab38e6ae04542455f5
author Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600
committer Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600

 arch/powerpc/kernel/setup_32.c |    2 +-
 arch/powerpc/kernel/setup_64.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
index 79d434f..e5d285a 100644
--- a/arch/powerpc/kernel/setup_32.c
+++ b/arch/powerpc/kernel/setup_32.c
@@ -299,7 +299,7 @@ void __init setup_arch(char **cmdline_p)
 	if (ppc_md.init_early)
 		ppc_md.init_early();
 
-#ifdef CONFIG_PPC_MULTIPLATFORM
+#ifdef CONFIG_SERIAL_8250
 	find_legacy_serial_ports();
 #endif
 	finish_device_tree();
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 419e0b9..98e9f05 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -472,7 +472,7 @@ void __init setup_system(void)
 	 * hash table management for us, thus ioremap works. We do that early
 	 * so that further code can be debugged
 	 */
-#ifdef CONFIG_PPC_MULTIPLATFORM
+#ifdef CONFIG_SERIAL_8250
 	find_legacy_serial_ports();
 #endif
 

Re: [PATCH] powerpc: Call find_legacy_serial_ports() if we enable CONFIG_SERIAL_8250

From: Stephen Rothwell <hidden>
Date: 2005-12-21 05:13:30

On Tue, 20 Dec 2005 20:45:27 -0600 (CST) Kumar Gala [off-list ref] wrote:
In setup_arch and setup_system call find_legacy_serial_ports() if we
build in support for 8250 serial ports instead of basing it on PPC_MULTIPLATFORM.

Signed-off-by: Kumar Gala <redacted>

---
commit 399e10aa1c6a3ca64e8e8e8cea7289e9908cc62c
tree 3e5320b8a97a37c4d010186aabf8a95e5be264b4
parent 7b69a37a4e811e72e82896ab38e6ae04542455f5
author Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600
committer Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600

 arch/powerpc/kernel/setup_32.c |    2 +-
 arch/powerpc/kernel/setup_64.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
You should probably change the Makefile as well to build legacy_serial.c
in the CONFIG_SERIAL_8250 case.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: [PATCH] powerpc: Call find_legacy_serial_ports() if we enable CONFIG_SERIAL_8250

From: Kumar Gala <hidden>
Date: 2005-12-21 15:31:19

On Dec 20, 2005, at 11:13 PM, Stephen Rothwell wrote:
On Tue, 20 Dec 2005 20:45:27 -0600 (CST) Kumar Gala [off-list ref] wrote:
quoted
In setup_arch and setup_system call find_legacy_serial_ports() if we
build in support for 8250 serial ports instead of basing it on PPC_MULTIPLATFORM.

Signed-off-by: Kumar Gala <redacted>

---
commit 399e10aa1c6a3ca64e8e8e8cea7289e9908cc62c
tree 3e5320b8a97a37c4d010186aabf8a95e5be264b4
parent 7b69a37a4e811e72e82896ab38e6ae04542455f5
author Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600
committer Kumar Gala [off-list ref] Tue, 20 Dec 2005 20:48:36 -0600

 arch/powerpc/kernel/setup_32.c |    2 +-
 arch/powerpc/kernel/setup_64.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
You should probably change the Makefile as well to build legacy_serial.c
in the CONFIG_SERIAL_8250 case.
Good call, was meaning to update the Makefile as well.  I'll send an updated patch with the Makefile change.

- kumar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help