5 messages, 4 authors, 2005-11-23 · open the first message on its own page
From: Vitaly Bordug <hidden>
Date: 2005-11-18 17:10:55
This adds adds PCMCIA supported for both MPC885ADS and MPC866ADS. This is established not together with FADS, because 885 does not have io_block_mapping() for BCSR area. Also, some cleanups done both for 885ADS and MBX. Signed-off-by: Vitaly Bordug <redacted> -- Sincerely, Vitaly
From: Marcelo Tosatti <hidden>
Date: 2005-11-23 18:24:31
Hi Vitaly, On Fri, Nov 18, 2005 at 07:42:51PM +0300, Vitaly Bordug wrote:
This adds adds PCMCIA supported for both MPC885ADS and MPC866ADS. This is established not together with FADS, because 885 does not have io_block_mapping() for BCSR area. Also, some cleanups done both for 885ADS and MBX. Signed-off-by: Vitaly Bordug <redacted>
<snip>
+ bcsr_io = ioremap(BCSR1, sizeof(unsigned long));
Shouldnt you handle ioremap() failure? Most 85xx code written by Kumar also does not.
From: Kumar Gala <hidden>
Date: 2005-11-23 18:41:56
On Nov 23, 2005, at 6:53 AM, Marcelo Tosatti wrote:
Hi Vitaly, On Fri, Nov 18, 2005 at 07:42:51PM +0300, Vitaly Bordug wrote:quoted
This adds adds PCMCIA supported for both MPC885ADS and MPC866ADS. This is established not together with FADS, because 885 does not have io_block_mapping() for BCSR area. Also, some cleanups done both for 885ADS and MBX. Signed-off-by: Vitaly Bordug <redacted><snip>quoted
+ bcsr_io = ioremap(BCSR1, sizeof(unsigned long));Shouldnt you handle ioremap() failure? Most 85xx code written by Kumar also does not.
Ok, I'll take a hint to go audit my code for ioremap() returns :) - kumar
From: Dan Malek <hidden>
Date: 2005-11-23 20:22:55
On Nov 23, 2005, at 7:53 AM, Marcelo Tosatti wrote:
Shouldnt you handle ioremap() failure? Most 85xx code written by Kumar also does not.
And do what if it fails? Chances are you don't have any way to report an error message or panic at this point. In fact, there are a few silly tests like this where the failure tries to panic or print some message that will never be seen. Fortunately, the code will never fail and we will never take such code paths. -- Dan
From: Marcelo Tosatti <hidden>
Date: 2005-11-23 20:45:19
On Wed, Nov 23, 2005 at 03:22:40PM -0500, Dan Malek wrote:
On Nov 23, 2005, at 7:53 AM, Marcelo Tosatti wrote:quoted
Shouldnt you handle ioremap() failure? Most 85xx code written by Kumar also does not.And do what if it fails? Chances are you don't have any way to report an error message or panic at this point. In fact, there are a few silly tests like this where the failure tries to panic or print some message that will never be seen. Fortunately, the code will never fail and we will never take such code paths.
OK! Was talking BS then.