[PATCH] powerpc: don't execute a temporary comment

Subsystems: the rest

STALE7663d

4 messages, 4 authors, 2005-09-16 · open the first message on its own page

[PATCH] powerpc: don't execute a temporary comment

From: Stephen Rothwell <hidden>
Date: 2005-09-15 06:04:30

Signed-off-by: Stephen Rothwell <redacted>
---

 arch/ppc/Makefile   |    2 +-
 arch/ppc64/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

86f7688825b1f1e6fa4c43bce001b2a232f7d1bc
diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
--- a/arch/ppc/Makefile
+++ b/arch/ppc/Makefile
@@ -102,9 +102,9 @@ define archhelp
   @echo '  *_defconfig     - Select default config from arch/$(ARCH)/ppc/configs'
 endef
 
+# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
 archclean:
 	$(Q)$(MAKE) $(clean)=arch/ppc/boot
-	# Temporary hack until we have migrated to asm-powerpc
 	$(Q)rm -rf arch/$(ARCH)/include
 
 archprepare: checkbin
diff --git a/arch/ppc64/Makefile b/arch/ppc64/Makefile
--- a/arch/ppc64/Makefile
+++ b/arch/ppc64/Makefile
@@ -113,9 +113,9 @@ defaultimage-$(CONFIG_PPC_ISERIES) := vm
 KBUILD_IMAGE := $(defaultimage-y)
 all: $(KBUILD_IMAGE)
 
+# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
-	# Temporary hack until we have migrated to asm-powerpc
 	$(Q)rm -rf arch/$(ARCH)/include
 
 

Re: [PATCH] powerpc: don't execute a temporary comment

From: John W. Linville <hidden>
Date: 2005-09-15 14:07:01

On Thu, Sep 15, 2005 at 04:04:30PM +1000, Stephen Rothwell wrote:
quoted hunk
--- a/arch/ppc/Makefile
+++ b/arch/ppc/Makefile
@@ -102,9 +102,9 @@ define archhelp
   @echo '  *_defconfig     - Select default config from arch/$(ARCH)/ppc/configs'
 endef
 
+# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
 archclean:
 	$(Q)$(MAKE) $(clean)=arch/ppc/boot
-	# Temporary hack until we have migrated to asm-powerpc
 	$(Q)rm -rf arch/$(ARCH)/include
 
 archprepare: checkbin
Why is this helpful?  Better in general to keep the commment near the code, no?

John
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] powerpc: don't execute a temporary comment

From: Paul Mackerras <hidden>
Date: 2005-09-15 22:55:57

John W. Linville writes:
Why is this helpful?  Better in general to keep the commment near the code, no?
Where it was, it was a command, not a comment, so it got printed out
on the screen when you did a make clean, which seemed a bit silly.

Paul.

Re: [PATCH] powerpc: don't execute a temporary comment

From: Kumar Gala <hidden>
Date: 2005-09-16 02:22:43

We are going to send this to Linus for 2.6.14, right?

- k

On Sep 15, 2005, at 5:55 PM, Paul Mackerras wrote:
John W. Linville writes:

quoted
Why is this helpful?  Better in general to keep the commment near the
code, no?

Where it was, it was a command, not a comment, so it got printed out
on the screen when you did a make clean, which seemed a bit silly.

Paul.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help