SRAM support for the Pegasos II platform

Hello,

You can find enclosed or at the URL a patch for the 2.6.14-rc1.
http://arrakin.homedns.org/~nicolas/mv643xx_eth_chrp_pegasos_eth.c.2.6.14-rc1.diff

It allows (with drivers/net/mv643xx_eth.*) to take advantage of the SRAM of
the Marvell Discovery II for the network driver.

Reviews and comments welcome.

I hope it could be include in upcomming 2.6.14.

Regards,
-- 
Nicolas DET
MorphOS & Linux developer

In article [off-list ref] you write:

You can find enclosed or at the URL a patch for the 2.6.14-rc1.
http://arrakin.homedns.org/~nicolas/mv643xx_eth_chrp_pegasos_eth.c.2.6.14-rc1.diff

It allows (with drivers/net/mv643xx_eth.*) to take advantage of the SRAM of
the Marvell Discovery II for the network driver.

Reviews and comments welcome.

Hi Nicolas,

+#define PEGASOS2_SRAM_SIZE				(0x00008000)

I think the SRAM is 256KB, so shouldn't this be 0x00040000 ?

-Dale

Nicolas DET [off-list ref] wrote:

You can find enclosed or at the URL a patch for the 2.6.14-rc1.
http://arrakin.homedns.org/~nicolas/mv643xx_eth_chrp_pegasos_eth.c.2.6.14-rc1.diff

It allows (with drivers/net/mv643xx_eth.*) to take advantage of the SRAM of
the Marvell Discovery II for the network driver.

I've kind of lost the plot with what happened with this patch.  Who is the
maintainer of this driver, and has [s]he commented on this patch?

The patch does strange things with whitespace: some places it uses spaces,
other places it uses tabs.  Please fix that up using hard tabs and resend. 
When doing so, please first review
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt for the patch
preparation protocol, thanks.

On Tue, Oct 11, 2005 at 08:50:22PM +0000, Andrew Morton wrote:

Nicolas DET [off-list ref] wrote:

quoted

You can find enclosed or at the URL a patch for the 2.6.14-rc1.
http://arrakin.homedns.org/~nicolas/mv643xx_eth_chrp_pegasos_eth.c.2.6.14-rc1.diff

It allows (with drivers/net/mv643xx_eth.*) to take advantage of the SRAM of
the Marvell Discovery II for the network driver.

I've kind of lost the plot with what happened with this patch.  Who is the
maintainer of this driver, and has [s]he commented on this patch?

I'm the maintainer of the 2.6 mv643xx_eth driver.  The only comment I had
(in http://ozlabs.org/pipermail/linuxppc-dev/2005-September/019764.html)
was that the define for PEGASOS2_SRAM_SIZE looks wrong.  When that and
the whitespace/style issues are fixed, I'm OK with the change.

-Dale