3 messages, 3 authors, 2005-02-23 · open the first message on its own page
From: Shawn Jin <hidden>
Date: 2005-02-23 18:46:49
Hi, This adds UBoot support on Ebony board and also sets emac's PHY mode explicitly during initialization as Eugene Surovegin provided. Regards, -Shawn.
From: Tom Rini <hidden>
Date: 2005-02-23 19:01:34
On Wed, Feb 23, 2005 at 10:39:34AM -0800, Shawn Jin wrote:
This adds UBoot support on Ebony board and also sets emac's PHY mode explicitly during initialization as Eugene Surovegin provided.
[snip]
+#include "../../../../drivers/net/ibm_emac/ibm_emac_phy.h"
This will not work with O= for example. The correct method is to modify the Makefile with a CFLAGS_foo.o += -Idrivers/net/ibm_emac -- Tom Rini http://gate.crashing.org/~trini/
From: Eugene Surovegin <hidden>
Date: 2005-02-23 19:12:52
On Wed, Feb 23, 2005 at 12:01:23PM -0700, Tom Rini wrote:
quoted
+#include "../../../../drivers/net/ibm_emac/ibm_emac_phy.h"This will not work with O= for example. The correct method is to modify the Makefile with a CFLAGS_foo.o += -Idrivers/net/ibm_emac
I just tested and it does work even with O= :). OTOH, I agree this is ugly hack (it was copied from ocotea.c, so blame Matt for it :) and should be fixed correctly by moving those PHY defines to some common include. -- Eugene