Re: [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup

On Thu, Feb 17, 2005 at 02:19:14AM +0100, Andre' Draszik wrote:

Hi,

Matt Porter wrote:

quoted

On Mon, Feb 07, 2005 at 05:24:55AM +0100, Andre' Draszik wrote:

quoted

Hi,

this is a rewrite of the ibm4xx ocp ide driver. In its current state it
[...]

I tried applying this to current linuxppc-2.5. All hunks are rejected.
Can you double check this patch and resend?

my kernel tree is
rsync -avz --delete source.mvista.com::linuxppc-2.5 linuxppc-2.5
and as of 16.02.05 23:44GMT the patch still applies. so did i really
send a wrong patch or has the rsync mirror just not yet been
updated? or is it a whitespace issue?

just checked - it's the last, so here's the patch, rediffed to
2.6.11-rc4, as attachment, not inline this time.

hope it works...

Ok, this one looks good save a few minor things that need done:

1) Rename from ibm_ocp_ide.[c|h] to ibm_stb_ide.[c|h] We want
   rid of "ocp" in the file names since eventually 4xx will
   convert to platform devices.

2) Remove the #if 0'ed code...if it's not used it doesn't belong
   in there.

3) Run Lindent on the driver.

What systems have you tested on?

-Matt

Hi,

Matt Porter wrote:

Ok, this one looks good save a few minor things that need done:

i will address these as soon as i have time again, i.e. on wednesday.

1) Rename from ibm_ocp_ide.[c|h] to ibm_stb_ide.[c|h] We want
   rid of "ocp" in the file names since eventually 4xx will
   convert to platform devices.

is diff -N appropriate for that and convenient for you? as said, i'm using 
the rsync mirror only, no bitkeeper.

2) Remove the #if 0'ed code...if it's not used it doesn't belong
   in there.

ok.

3) Run Lindent on the driver.

ok.
Shall I send the new patch against the one I already sent or against the 
unpatched tree?

What systems have you tested on?

On two different custom built boards both based on the redwood5 reference 
design.


a.