[PATCH] netdrv gianfar: Fix usage of gfar_read in debug code

STALE7880d

2 messages, 2 authors, 2005-01-27 · open the first message on its own page

[PATCH] netdrv gianfar: Fix usage of gfar_read in debug code

From: Kumar Gala <hidden>
Date: 2005-01-26 00:20:51

Fixes instances where gfar_read() was invoked in debug codewith a value, 
rather than a pointer.

Signed-of-by: Andy Fleming [off-list ref]
Signed-of-by: Kumar Gala [off-list ref]

---

diff -Nru a/drivers/net/gianfar.c b/drivers/net/gianfar.c
--- a/drivers/net/gianfar.c	2005-01-25 18:14:13 -06:00
+++ b/drivers/net/gianfar.c	2005-01-25 18:14:13 -06:00
@@ -1190,8 +1190,8 @@
 	} else {
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: receive called twice (%x)[%x]\n",
-		       dev->name, gfar_read(priv->regs->ievent),
-		       gfar_read(priv->regs->imask));
+		       dev->name, gfar_read(&priv->regs->ievent),
+		       gfar_read(&priv->regs->imask));
 #endif
 	}
 #else
@@ -1415,7 +1415,7 @@
 
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: busy error (rhalt: %x)\n", dev->name,
-		       gfar_read(priv->regs->rstat));
+		       gfar_read(&priv->regs->rstat));
 #endif
 	}
 	if (events & IEVENT_BABR) {
@@ -1793,7 +1793,7 @@
 
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: busy error (rhalt: %x)\n", dev->name,
-		       gfar_read(priv->regs->rstat));
+		       gfar_read(&priv->regs->rstat));
 #endif
 	}
 	if (events & IEVENT_BABR) {

Re: [PATCH] netdrv gianfar: Fix usage of gfar_read in debug code

From: Jeff Garzik <hidden>
Date: 2005-01-27 22:10:58

applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help