[PATCH] export m8xx_cpm_hostalloc

STALE8044d

5 messages, 3 authors, 2004-07-23 · open the first message on its own page

[PATCH] export m8xx_cpm_hostalloc

From: Andreas Oberritter <hidden>
Date: 2004-07-23 13:49:27

Hi Tom,

to build an i2c driver as a module, m8xx_cpm_hostalloc must be exported.
We are using a driver which is not in the kernel tree[1]. I tried to
merge the in-kernel i2c driver with it, but I failed and don't have the
time to investigate why our driver works with the dbox2 board and the
in-kernel driver doesn't.

This function has been exported in 2.4. Is it ok to do that for 2.6,
too?

Regards,
Andreas

[1]:
http://cvs.tuxbox.org/cgi-bin/viewcvs.cgi/tuxbox/driver/i2c/dbox2_i2c.c?rev=1.28&content-type=text/vnd.viewcvs-markup


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] export m8xx_cpm_hostalloc

From: Andreas Oberritter <hidden>
Date: 2004-07-23 13:51:44

Forgot to attach the patch, so here it is.

Re: [PATCH] export m8xx_cpm_hostalloc

From: Tom Rini <hidden>
Date: 2004-07-23 14:02:31

On Fri, Jul 23, 2004 at 03:49:27PM +0200, Andreas Oberritter wrote:
Hi Tom,

to build an i2c driver as a module, m8xx_cpm_hostalloc must be exported.
We are using a driver which is not in the kernel tree[1]. I tried to
merge the in-kernel i2c driver with it, but I failed and don't have the
time to investigate why our driver works with the dbox2 board and the
in-kernel driver doesn't.

This function has been exported in 2.4. Is it ok to do that for 2.6,
too?
Must the driver use hostalloc?  I didn't think that i2c was called so
early that kmalloc/bootmem_alloc() (or so) couldn't be used.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] export m8xx_cpm_hostalloc

From: Dan Malek <hidden>
Date: 2004-07-23 14:41:36

On Jul 23, 2004, at 10:02 AM, Tom Rini wrote:
Must the driver use hostalloc?  I didn't think that i2c was called so
early that kmalloc/bootmem_alloc() (or so) couldn't be used.

Should use ...consistent_alloc()


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] export m8xx_cpm_hostalloc

From: Tom Rini <hidden>
Date: 2004-07-23 14:42:57

On Fri, Jul 23, 2004 at 10:41:36AM -0400, Dan Malek wrote:
On Jul 23, 2004, at 10:02 AM, Tom Rini wrote:
quoted
Must the driver use hostalloc?  I didn't think that i2c was called so
early that kmalloc/bootmem_alloc() (or so) couldn't be used.
Should use ...consistent_alloc()
Not having the full context handy (and trying to listen to rml right
now), yes, that too could be the correct answer here.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help