5 messages, 3 authors, 2004-01-12 · open the first message on its own page
From: Colin Leroy <colin@colino.net>
Date: 2003-12-20 16:58:50
Hi, I noticed that when pushed to the upper limits, the mixer channels on my ibook G4 just went silent (tested with master, bass, treble). I found out this was due to too short (by one item) arrays in tas3004_tables.c. This patch fixes it. I just copied over the last entry of each array. HTH, -- Colin http://www.colino.net/
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2003-12-20 23:26:14
On Sun, 2003-12-21 at 03:58, Colin Leroy wrote:
Hi, I noticed that when pushed to the upper limits, the mixer channels on my ibook G4 just went silent (tested with master, bass, treble). I found out this was due to too short (by one item) arrays in tas3004_tables.c. This patch fixes it. I just copied over the last entry of each array.
Interesting, my understanding is that those values were taken from Darwin ;) I'll look at this too along with your fan stuff and merge, thanks. Ben. ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
From: Colin Leroy <colin@colino.net>
Date: 2003-12-21 11:23:29
On 21 Dec 2003 at 10h12, Benjamin Herrenschmidt wrote: Hi,
quoted
I found out this was due to too short (by one item) arrays in tas3004_tables.c. This patch fixes it. I just copied over the last entry of each array.Interesting, my understanding is that those values were taken from Darwin ;)
That's what I thought too; that's a bit odd. debug printk()s clearly told me that the kernel was trying to get array[101] of the 101 elements arrays :-) Maybe Darwin doesn't allow the mixers to get to 100% ? -- Colin ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
From: Segher Boessenkool <hidden>
Date: 2004-01-09 22:33:24
quoted
I found out this was due to too short (by one item) arrays in tas3004_tables.c. This patch fixes it. I just copied over the last entry of each array.Interesting, my understanding is that those values were taken from Darwin ;) I'll look at this too along with your fan stuff and merge, thanks.
It could be these tables are taken from Darwin, but there is no need for that; the chip manual contains those tables, too (but for a bigger range of values). Segher ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
From: Colin Leroy <colin@colino.net>
Date: 2004-01-12 11:45:41
On 09 Jan 2004 at 23h01, Segher Boessenkool wrote: Hi,
It could be these tables are taken from Darwin, but there is no need for that; the chip manual contains those tables, too (but for a bigger range of values).
By the way, this was for kernel 2.4 and dmasound. Alsa drivers in 2.6 work fine. -- Colin ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/