8xx drivers for 2.6

8 messages, 5 authors, 2003-12-22 · open the first message on its own page

8xx drivers for 2.6

From: Tom Rini <hidden>
Date: 2003-12-11 19:18:54 

Ok.  I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the simpler
changes to head_8xx.S.  You can get the patch at
http://stop.crashing.org:16080/~trini/XXX-mpc8xx_round_one.patch
or below.  There are a few issues that could still use additional work
(serial), and in 2.6 having request_8xxirq becomes much uglier because
of the irqreturn_t stuff (at least I couldn't make it happen w/o chaning
<linux/interrupt.h>, and I never did figure out why cond_syscall()
doesn't work in some files but not others.

Dan, if you have _anything_ done for head_8xx.S can you please post it?
Thanks.

--
Tom Rini
http://gate.crashing.org/~trini/

Re: 8xx drivers for 2.6

From: Dan Malek <hidden>
Date: 2003-12-11 19:44:50 

Tom Rini wrote:

Ok. I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the
simpler changes to head_8xx.S.
Thanks.  So, does the kernel at least compile now?  :-)

...and in 2.6 having request_8xxirq becomes much uglier because of the
irqreturn_t stuff
I'm finally going to update this.  I've got a pretty good implemenation
of the cascaded controller stuff for the 8560, once I get this debugged
I'll port it here.

Dan, if you have _anything_ done for head_8xx.S can you please post
it?
Yeah, maybe I can do some debug now, too.

Thanks.

	-- Dan

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 8xx drivers for 2.6

From: Tom Rini <hidden>
Date: 2003-12-11 21:25:29 

On Thu, Dec 11, 2003 at 02:44:50PM -0500, Dan Malek wrote:
Tom Rini wrote:
quoted
Ok. I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the
simpler changes to head_8xx.S.
Thanks. So, does the kernel at least compile now? :-)
Compiles, links, boots and happily dies inside of head_8xx.S :)
quoted
...and in 2.6 having request_8xxirq becomes much uglier because of
the irqreturn_t stuff
I'm finally going to update this. I've got a pretty good implemenation
of the cascaded controller stuff for the 8560, once I get this
debugged I'll port it here.
Sounds like a plan.
quoted
Dan, if you have _anything_ done for head_8xx.S can you please post
it?
Yeah, maybe I can do some debug now, too.
Hopefully :)

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 8xx drivers for 2.6

From: Pantelis Antoniou <hidden>
Date: 2003-12-15 12:13:06 

Tom Rini wrote:

On Thu, Dec 11, 2003 at 02:44:50PM -0500, Dan Malek wrote:
quoted
Tom Rini wrote:
quoted
Ok. I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the
simpler changes to head_8xx.S.

Thanks. So, does the kernel at least compile now? :-)

Compiles, links, boots and happily dies inside of head_8xx.S :)
quoted
quoted
...and in 2.6 having request_8xxirq becomes much uglier because of
the irqreturn_t stuff

I'm finally going to update this. I've got a pretty good implemenation
of the cascaded controller stuff for the 8560, once I get this
debugged I'll port it here.

Sounds like a plan.
quoted
quoted
Dan, if you have _anything_ done for head_8xx.S can you please post
it?
Yeah, maybe I can do some debug now, too.
Hopefully :)

--
Tom Rini
http://gate.crashing.org/~trini/




That sounds nice.

Any chance to push the changes to the linuxppc-2.5 tree for us poor saps?
It doesn't have to work or anything, just give us something to work...

Regards

Pantelis


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 8xx drivers for 2.6

From: Tom Rini <hidden>
Date: 2003-12-15 16:18:15 

On Mon, Dec 15, 2003 at 02:13:06PM +0200, Pantelis Antoniou wrote:
Tom Rini wrote:
quoted
On Thu, Dec 11, 2003 at 02:44:50PM -0500, Dan Malek wrote:
quoted
Tom Rini wrote:
quoted
Ok. I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the
simpler changes to head_8xx.S.

Thanks. So, does the kernel at least compile now? :-)
Compiles, links, boots and happily dies inside of head_8xx.S :)
quoted
quoted
...and in 2.6 having request_8xxirq becomes much uglier because of
the irqreturn_t stuff

I'm finally going to update this. I've got a pretty good implemenation
of the cascaded controller stuff for the 8560, once I get this
debugged I'll port it here.
Sounds like a plan.
quoted
quoted
Dan, if you have _anything_ done for head_8xx.S can you please post
it?
Yeah, maybe I can do some debug now, too.
Hopefully :)
That sounds nice.

Any chance to push the changes to the linuxppc-2.5 tree for us poor saps?
It doesn't have to work or anything, just give us something to work...
Sure, done.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 8xx drivers for 2.6

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2003-12-21 12:31:40 

On Mon, 15 Dec 2003, Tom Rini wrote:
On Mon, Dec 15, 2003 at 02:13:06PM +0200, Pantelis Antoniou wrote:
quoted
Tom Rini wrote:
quoted
On Thu, Dec 11, 2003 at 02:44:50PM -0500, Dan Malek wrote:
quoted
Tom Rini wrote:
quoted
Ok. I've gone and ported the 8xx serial driver, and other misc 8xx
things up to what 2.6 wants them to be, as well as a few of the
simpler changes to head_8xx.S.

Thanks. So, does the kernel at least compile now? :-)
Compiles, links, boots and happily dies inside of head_8xx.S :)
quoted
quoted
...and in 2.6 having request_8xxirq becomes much uglier because of
the irqreturn_t stuff
That sounds nice.

Any chance to push the changes to the linuxppc-2.5 tree for us poor saps?
It doesn't have to work or anything, just give us something to work...
Sure, done.
quoted hunk
diff -Nru a/include/linux/interrupt.h b/include/linux/interrupt.h
--- a/include/linux/interrupt.h	Thu Dec 11 12:14:00 2003
+++ b/include/linux/interrupt.h	Thu Dec 11 12:14:00 2003
@@ -26,7 +26,9 @@
  * IRQ_HANDLED means that we did have a valid interrupt and handled it.
  * IRQ_RETVAL(x) selects on the two depending on x being non-zero (for handled)
  */
+#ifndef __CONFIG_8xx_DEFS
 typedef int irqreturn_t;
+#endif

 #define IRQ_NONE	(0)
 #define IRQ_HANDLED	(1)
And this breaks compilation for non-8xx machines in current linuxppc-2.5:

| In file included from arch/ppc/kernel/traps.c:29:
| include/linux/interrupt.h:38: error: parse error before "irqreturn_t"

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





  

    
Re: 8xx drivers for 2.6

    

      From: Paul Mackerras <hidden>

      Date: 2003-12-21 21:39:20 
    

  

  
Tom Rini writes:

(serial), and in 2.6 having request_8xxirq becomes much uglier because
of the irqreturn_t stuff (at least I couldn't make it happen w/o chaning
<linux/interrupt.h>, and I never did figure out why cond_syscall()
doesn't work in some files but not others.
Gaahhhh, I thought we had got rid of request_8xxirq.  I don't want to
see it come back.  And this sort of thing is just bad:

quoted hunk
diff -Nru a/include/asm-ppc/mpc8xx.h b/include/asm-ppc/mpc8xx.h
--- a/include/asm-ppc/mpc8xx.h	Thu Dec 11 12:14:00 2003
+++ b/include/asm-ppc/mpc8xx.h	Thu Dec 11 12:14:00 2003
@@ -96,8 +96,10 @@
 extern unsigned char __res[];

 struct pt_regs;
+typedef int irqreturn_t;	/* FIXME -- Tom */
+
[snip]

quoted hunk
diff -Nru a/include/linux/interrupt.h b/include/linux/interrupt.h
--- a/include/linux/interrupt.h	Thu Dec 11 12:14:00 2003
+++ b/include/linux/interrupt.h	Thu Dec 11 12:14:00 2003
@@ -26,7 +26,9 @@
  * IRQ_HANDLED means that we did have a valid interrupt and handled it.
  * IRQ_RETVAL(x) selects on the two depending on x being non-zero (for handled)
  */
+#ifndef __CONFIG_8xx_DEFS
 typedef int irqreturn_t;
+#endif
Paul.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





  

    
Re: 8xx drivers for 2.6

    

      From: Dan Malek <hidden>

      Date: 2003-12-22 09:00:21 
    

  

  
Paul Mackerras wrote:

Gaahhhh, I thought we had got rid of request_8xxirq.  I don't want to
see it come back.  And this sort of thing is just bad.
I don't know why in the hell this has irritated you so badly.
It's 10 lines of code to allow people to use those legacy PC devices
on boards like the MBX860 have have an 8259 controller.

In any case, since the 2.4 was screwed up so badly when it was
removed there, I have removed it from 2.6. I'm just building various
configurations right now to ensure I didn't break some non-8xx stuff
in the process.

Thanks.


	-- Dan


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help