2.6.0-test2-bk2 (linus' tree) -- arch/ppc/platforms/pmac_cpufreq.c:219: undefined reference to `cpufreq_frequency_table_verify'

After patching arch/ppc/kernel/setup.c to include cpu.h,
I got this error:

  LD      .tmp_vmlinux1
arch/ppc/platforms/built-in.o(.pmac.text+0x584c): In function
`pmac_cpufreq_setup':
arch/ppc/platforms/pmac_cpufreq.c:219: undefined reference to
`cpufreq_frequency_table_verify'
arch/ppc/platforms/built-in.o(.pmac.text+0x588c):arch/ppc/platforms/pmac_cpufreq.c:229:
undefined reference to `cpufreq_frequency_table_target'
arch/ppc/platforms/built-in.o(.pmac.text+0x5930):arch/ppc/platforms/pmac_cpufreq.c:254:
undefined reference to `cpufreq_frequency_table_cpuinfo'
make: *** [.tmp_vmlinux1] Error 1

CONFIG_PPC=y
CONFIG_PPC32=y
CONFIG_6xx=y

CONFIG_PM=y
# CONFIG_8260 is not set
CONFIG_GENERIC_ISA_DMA=y
CONFIG_PPC_STD_MMU=y
CONFIG_PPC_MULTIPLATFORM=y
CONFIG_PPC_CHRP=y
CONFIG_PPC_PMAC=y
CONFIG_PPC_PREP=y
CONFIG_PPC_OF=y
CONFIG_ALTIVEC=y
CONFIG_TAU=y
# CONFIG_TAU_INT is not set
CONFIG_TAU_AVERAGE=y
CONFIG_CPU_FREQ=y
# CONFIG_CPU_FREQ_PROC_INTF is not set
CONFIG_CPU_FREQ_24_API=y
CONFIG_CPU_FREQ_PMAC=y

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

On Sun, 2003-08-03 at 23:56, Miles Lane wrote:

After patching arch/ppc/kernel/setup.c to include cpu.h,
I got this error:

  LD      .tmp_vmlinux1
arch/ppc/platforms/built-in.o(.pmac.text+0x584c): In function
`pmac_cpufreq_setup':
arch/ppc/platforms/pmac_cpufreq.c:219: undefined reference to
`cpufreq_frequency_table_verify'
arch/ppc/platforms/built-in.o(.pmac.text+0x588c):arch/ppc/platforms/pmac_cpufreq.c:229:
undefined reference to `cpufreq_frequency_table_target'
arch/ppc/platforms/built-in.o(.pmac.text+0x5930):arch/ppc/platforms/pmac_cpufreq.c:254:
undefined reference to `cpufreq_frequency_table_cpuinfo'
make: *** [.tmp_vmlinux1] Error 1

That's some Kconfig not up-to-date yet. I'm sorting out various
missing pmac patches for Linus and will send them over next week,
including that. You basically need CPU_FREQ_TABLE for now.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

On Sun August 3 2003 3:01 pm, Benjamin Herrenschmidt wrote:

On Sun, 2003-08-03 at 23:56, Miles Lane wrote:

quoted

After patching arch/ppc/kernel/setup.c to include cpu.h,
I got this error:

  LD      .tmp_vmlinux1
arch/ppc/platforms/built-in.o(.pmac.text+0x584c): In function
`pmac_cpufreq_setup':
arch/ppc/platforms/pmac_cpufreq.c:219: undefined reference to
`cpufreq_frequency_table_verify'
arch/ppc/platforms/built-in.o(.pmac.text+0x588c):arch/ppc/platforms/pmac_
cpufreq.c:229: undefined reference to `cpufreq_frequency_table_target'
arch/ppc/platforms/built-in.o(.pmac.text+0x5930):arch/ppc/platforms/pmac_
cpufreq.c:254: undefined reference to `cpufreq_frequency_table_cpuinfo'
make: *** [.tmp_vmlinux1] Error 1

That's some Kconfig not up-to-date yet. I'm sorting out various
missing pmac patches for Linus and will send them over next week,
including that. You basically need CPU_FREQ_TABLE for now.

Thanks, Ben.  I tried adding "CPU_FREQ_TABLE=y"
and still got the error, though.

	Miles

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

On Sun August 3 2003 3:01 pm, Benjamin Herrenschmidt wrote:

On Sun, 2003-08-03 at 23:56, Miles Lane wrote:

quoted

After patching arch/ppc/kernel/setup.c to include cpu.h,
I got this error:

  LD      .tmp_vmlinux1
arch/ppc/platforms/built-in.o(.pmac.text+0x584c): In function
`pmac_cpufreq_setup':
arch/ppc/platforms/pmac_cpufreq.c:219: undefined reference to
`cpufreq_frequency_table_verify'
arch/ppc/platforms/built-in.o(.pmac.text+0x588c):arch/ppc/platforms/pmac_
cpufreq.c:229: undefined reference to `cpufreq_frequency_table_target'
arch/ppc/platforms/built-in.o(.pmac.text+0x5930):arch/ppc/platforms/pmac_
cpufreq.c:254: undefined reference to `cpufreq_frequency_table_cpuinfo'
make: *** [.tmp_vmlinux1] Error 1

That's some Kconfig not up-to-date yet. I'm sorting out various
missing pmac patches for Linus and will send them over next week,
including that. You basically need CPU_FREQ_TABLE for now.

Uh, rats.  It looks like KConfig won't let me edit .config by hand.
It strips out me addition.  How do I get around this?

Puzzled,

	Miles

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Benjamin Herrenschmidt writes:

That's some Kconfig not up-to-date yet. I'm sorting out various
missing pmac patches for Linus and will send them over next week,
including that. You basically need CPU_FREQ_TABLE for now.

Here is what I have in a tree locally to go to Linus.  I can't push it
out because ppc.bkbits.net seems to be down.

Paul.

diff -urN linux-2.5/arch/ppc/Kconfig for-linus-ppc/arch/ppc/Kconfig

--- linux-2.5/arch/ppc/Kconfig	2003-08-04 09:47:00.000000000 +1000
+++ for-linus-ppc/arch/ppc/Kconfig	2003-08-04 14:05:07.000000000 +1000

@@ -473,7 +473,6 @@
 	help
 	  Select SANDPOINT if configuring for a Motorola Sandpoint X3
 	  or X3(b).
-	  X3 (any flavor).

 config ADIR
 	bool "SBS-Adirondack"

@@ -693,6 +692,11 @@

 	  If in doubt, say N.

+config CPU_FREQ_TABLE
+	bool
+	depends on CPU_FREQ
+	default y
+
 config CPU_FREQ_PROC_INTF
 	bool "/proc/cpufreq interface (DEPRECATED)"
 	depends on CPU_FREQ && PROC_FS

diff -urN linux-2.5/arch/ppc/kernel/setup.c for-linus-ppc/arch/ppc/kernel/setup.c

--- linux-2.5/arch/ppc/kernel/setup.c	2003-08-02 09:37:29.000000000 +1000
+++ for-linus-ppc/arch/ppc/kernel/setup.c	2003-08-04 14:00:35.000000000 +1000

@@ -15,6 +15,7 @@
 #include <linux/bootmem.h>
 #include <linux/seq_file.h>
 #include <linux/root_dev.h>
+#include <linux/cpu.h>

 #include <asm/residual.h>
 #include <asm/io.h>

diff -urN linux-2.5/arch/ppc/lib/string.S for-linus-ppc/arch/ppc/lib/string.S

--- linux-2.5/arch/ppc/lib/string.S	2003-01-13 22:17:02.000000000 +1100
+++ for-linus-ppc/arch/ppc/lib/string.S	2003-08-04 14:32:06.000000000 +1000

@@ -78,6 +78,8 @@
 	bne	1b
 	blr

+/* This clears out any unused part of the destination buffer,
+   just as the libc version does.  -- paulus */
 _GLOBAL(strncpy)
 	cmpwi	0,r5,0
 	beqlr

@@ -88,6 +90,12 @@
 	cmpwi	0,r0,0
 	stbu	r0,1(r6)
 	bdnzf	2,1b		/* dec ctr, branch if ctr != 0 && !cr0.eq */
+	bnelr			/* if we didn't hit a null char, we're done */
+	mfctr	r5
+	cmpwi	0,r5,0		/* any space left in destination buffer? */
+	beqlr			/* we know r0 == 0 here */
+2:	stbu	r0,1(r6)	/* clear it out if so */
+	bdnz	2b
 	blr

 _GLOBAL(strcat)

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Here is what I have in a tree locally to go to Linus.  I can't push it
out because ppc.bkbits.net seems to be down.

It's back.  If anyone has any insight into how to track down kernel hangs
I'd love to hear them.  bkbits.net has been flakey in the last couple of
months and sometimes just hangs, last night's was with pings still working
but no response at the console.
--
---
Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

On Mon, 2003-08-04 at 17:26, Larry McVoy wrote:

quoted

Here is what I have in a tree locally to go to Linus.  I can't push it
out because ppc.bkbits.net seems to be down.

It's back.  If anyone has any insight into how to track down kernel hangs
I'd love to hear them.  bkbits.net has been flakey in the last couple of
months and sometimes just hangs, last night's was with pings still working
but no response at the console.

Which kernel is it running? Something like this happened to every 2.4.21
kernel I've tried soon after they hit swap. I thought it might be a bad
interaction of the 2.4.21 VM, CONFIG_HIGHMEM and the XFS and whatnot
patches and went back to good old 2.4.20-ben8.


--
Earthling Michel Dänzer   \  Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast  \     http://svcs.affero.net/rm.php?r=daenzer


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

On Mon, Aug 04, 2003 at 05:39:09PM +0200, Michel D?nzer wrote:

On Mon, 2003-08-04 at 17:26, Larry McVoy wrote:

quoted

quoted

Here is what I have in a tree locally to go to Linus.  I can't push it
out because ppc.bkbits.net seems to be down.

It's back.  If anyone has any insight into how to track down kernel hangs
I'd love to hear them.  bkbits.net has been flakey in the last couple of
months and sometimes just hangs, last night's was with pings still working
but no response at the console.

Which kernel is it running? Something like this happened to every 2.4.21
kernel I've tried soon after they hit swap. I thought it might be a bad
interaction of the 2.4.21 VM, CONFIG_HIGHMEM and the XFS and whatnot
patches and went back to good old 2.4.20-ben8.

2.4.20 and I am using CONFIG_HIGHMEM.  It's on a serverworks chipset and
maybe that's causing problems.  I need to get off IDE.
--
---
Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/