cleanup of linux-2.5/drivers/block/swim3.c

4 messages, 4 authors, 2003-07-12 · open the first message on its own page

cleanup of linux-2.5/drivers/block/swim3.c

From: Jasper Spaans <hidden>
Date: 2003-07-04 10:46:16

Hello,

Attached is a patch which should solve compilation issues related to the new
irqhandler interface, and the deprecation of cli()/sti() for the
swim3-driver.

Can you take a look, and possibly, apply this? (I don't have any hardware to
test this on, however it compiles)

VrGr,
--
Jasper Spaans [not on the linuxppc-dev list, so please Cc me]


<==          ``Got no clue? Too bad for you''          ==>
<==                                                    ==>

Re: cleanup of linux-2.5/drivers/block/swim3.c

From: Paul Mackerras <hidden>
Date: 2003-07-04 22:53:16

Jasper Spaans writes:
Attached is a patch which should solve compilation issues related to the new
irqhandler interface, and the deprecation of cli()/sti() for the
swim3-driver.
Have you audited the driver with respect to changes in the block
device layer?  I haven't, but I think it needs to be done.  It's
possible that the necessary changes have already been done but I'm not
sure.  And I don't want to send Linus a patch that would change it
from broken and non-compiling to broken but compiling.

Paul.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: cleanup of linux-2.5/drivers/block/swim3.c

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2003-07-06 19:04:49

On Fri, 2003-07-04 at 12:46, Jasper Spaans wrote:
Hello,

Attached is a patch which should solve compilation issues related to the new
irqhandler interface, and the deprecation of cli()/sti() for the
swim3-driver.

Can you take a look, and possibly, apply this? (I don't have any hardware to
test this on, however it compiles)
I'll take a look, but swim3 need more drastic updates for the new
BIO stuff, the new macio device interface, etc... It's on my list
once I'm done with a few other things.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: cleanup of linux-2.5/drivers/block/swim3.c

From: Boris Bezlaj <hidden>
Date: 2003-07-12 18:15:57

On Fri, Jul 04, 2003 at 12:46:16PM +0200, Jasper Spaans wrote:
Hello,

Attached is a patch which should solve compilation issues related to the new
irqhandler interface, and the deprecation of cli()/sti() for the
swim3-driver.

Can you take a look, and possibly, apply this? (I don't have any hardware to
test this on, however it compiles)
You did not take into account the changes made to swim3 driver in 2.4
kernel (fixing write operation) made by Paul.

I will try to merge the two and update BIO stuff. I'm not so sure about
the new macio device interface..should be fun :)

--

		Boris


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help