RE: PATCH: arch/ppc/8xx_io_fec.c

Yes.  There are silicon revisions that require the FEC to
be enabled for the MDIO to operate.

I tested on revisions B3 and D4, and did not see any problem.
Anyway, fec_stop was already disabling the FEC,
so if it was a problem, it would have broken there.

The code formatting looks like crap, so that needs to be fixed.

Do you mean for the mixed tabs/spaces? :-( Sorry for that one...
I will fix and resubmit as soon as everyone agree on the changes.

Regards,

Jean-Denis Boyer

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Jean-Denis Boyer wrote:

I tested on revisions B3 and D4, and did not see any problem.
Anyway, fec_stop was already disabling the FEC,
so if it was a problem, it would have broken there.

OK.  Just remember I mentioned this and be ready to fix it
when someone complains. :-)

Do you mean for the mixed tabs/spaces? :-( Sorry for that one...
I will fix and resubmit as soon as everyone agree on the changes.

Yes, and there is a Linux coding standards document that would be
nice if people followed:

	if (condition) {

not,
	if(condition){, or if( condition ){, or other weird variations

Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/