GUARDED attribute not set by consistent_alloc()

Hi

While browsing the tree I noticed that consistent_alloc() does not
set the _PAGE_GUARDED attribute(only _PAGE_KERNEL and _PAGE_NO_CACHE)
on the allocated memory.

ioremap() adds _PAGE_GUARDED if _PAGE_NO_CACHE is set. Should not
consistent_alloc() also add _PAGE_GUARDED?

  Jocke


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Joakim Tjernlund wrote:

ioremap() adds _PAGE_GUARDED if _PAGE_NO_CACHE is set. Should not
consistent_alloc() also add _PAGE_GUARDED?

No.  ioremap() is used to map device registers, where operation
order is important.  consistent_alloc() maps real memory, where
setting guarded wouldn't change any behavior and would cost
significant pipeline drain cycles.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/