Re: 8260/8xx Embedded Boot patch

2 messages, 2 authors, 2002-08-28 · open the first message on its own page

Re: 8260/8xx Embedded Boot patch

From: <hidden>
Date: 2002-08-28 00:28:29

The first thing I saw was the define_bool CONFIG_ALL_PPC n.
If this was actually needed someplace, there's a bug there that needs to
be fixed.
This is not required. All of the xxxx8260_defconfig files define this so you do
not get all of the generic Mac stuff like IDE and video. If it is not appropriate
take it out. It just serves to weed out a lot of options you are just going to
turn-off anyway.

------------------------------------------------------------
Allen Curtis              |  All good things come to those
Ones and Zeros, Inc.      |  who wait. Some of us have to
mailto:acurtis@onz.com    |  wait a little longer.

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: 8260/8xx Embedded Boot patch

From: Tom Rini <hidden>
Date: 2002-08-28 00:36:12

On Tue, Aug 27, 2002 at 05:28:29PM -0700, acurtis@onz.com wrote:
quoted
The first thing I saw was the define_bool CONFIG_ALL_PPC n.
If this was actually needed someplace, there's a bug there that needs to
be fixed.
This is not required. All of the xxxx8260_defconfig files define this so you do
not get all of the generic Mac stuff like IDE and video. If it is not appropriate
take it out. It just serves to weed out a lot of options you are just going to
turn-off anyway.
They shouldn't show up on 8260, since they don't show up on other,
non-CONFIG_ALL_PPC platforms.  Again, if they show up it's a bug.  The
bug is doing:
dep_{tristate,bool} 'Some pmac-specific driver' CONFIG_PMACSPEC $CONFIG_ALL_PPC
It should be:
if [ "$CONFIG_ALL_PPC" = "y" ]; then
   {bool,tristate} 'Some pmac-specific driver' CONFIG_PMACSPEC
fi

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help