Re: [PATCH] Hymod board support and related changes ...

On Tue, 28 May 2002 13:19:57 -0700, Tom Rini [off-list ref] writes:

On Tue, May 28, 2002 at 01:18:10PM -0700, Tom Rini wrote:

quoted

On Tue, May 28, 2002 at 03:48:35PM +1000, Murray Jensen wrote:

quoted

- Hymod board support

For the m8260_gorom() call, try using spin_lock_irqsave() instead of
save_flags();cli() ... restore_flags();

Nevermind, spoke too soon here.  But did you really need to add in what
you did or is it just a cleanup?

I needed to add it. When I executed a "halt" on my Hymod board, at the point
where it jumped to the ROM (in my case, this is ppcboot) things went crazy -
it caught an exception and tried to print a message on the console, but it was
really wierd, with only a few of the characters legible, others being
substituted with wierd umlauts or punctuation etc. I couln't see any pattern,
but when I turned off interrupts before executing the "gorom" function it
stopped. Note that this only started happening recently, so something changed
somewhere else which caused this problem.

The idea behind this fix is "correct" anyway. We do not want to take any
exceptions once we have jumped to the boot ROM code. With the code the way it is,
it is possible for interrupts to be enabled at the time the "gorom" function is
executed.

Maybe the proper fix is for "gorom" to ensure interrupts are disabled? Cheers!
								Murray...
--
Murray Jensen, CSIRO Manufacturing Sci & Tech,         Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia.         Fax: +61 3 9662 7853
Internet: Murray.Jensen@csiro.au

Hymod project: http://www.msa.cmst.csiro.au/projects/Hymod/


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

On Wed, May 29, 2002 at 12:07:16PM +1000, Murray Jensen wrote:

On Tue, 28 May 2002 13:19:57 -0700, Tom Rini [off-list ref] writes:

quoted

On Tue, May 28, 2002 at 01:18:10PM -0700, Tom Rini wrote:

quoted

On Tue, May 28, 2002 at 03:48:35PM +1000, Murray Jensen wrote:

quoted

- Hymod board support

For the m8260_gorom() call, try using spin_lock_irqsave() instead of
save_flags();cli() ... restore_flags();

Nevermind, spoke too soon here.  But did you really need to add in what
you did or is it just a cleanup?

I needed to add it. When I executed a "halt" on my Hymod board, at the point
where it jumped to the ROM (in my case, this is ppcboot) things went crazy -
it caught an exception and tried to print a message on the console, but it was
really wierd, with only a few of the characters legible, others being
substituted with wierd umlauts or punctuation etc. I couln't see any pattern,
but when I turned off interrupts before executing the "gorom" function it
stopped. Note that this only started happening recently, so something changed
somewhere else which caused this problem.

Well, this is also at powerdown, yes?  Or can we actually power off the
board with the gorom call, rather than just exit Linux?  If so,
nevermind..

Maybe the proper fix is for "gorom" to ensure interrupts are disabled? Cheers!

Nah.  It's an 8260-specific function, so I don't think it matters, so
why not just do it from the caller..  With a comment above that reminds
people grep'ing around that we're about to powerdown so it's OK to do
the save_flags();cli(); ... restore_flags();

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/