2.4.19-pre8-ben0 acenic driver and 867 MHz G4 sound problems

Hi,

First, thanks to BenH for his fix in the 2.4.19-pre8-ben0 kernel that
once again allows booting of the 867 MHz G4.  Unfortunately, I now have
a new problem as the acenic driver is now broken (using a NetGear GA620
NIC).  The previously working version was from a 2.4.17-pre2-ben0 kernel.
I can send a diff between the two sources if that would be of any help.

Also, is there any update on why sound doesn't work on the 867?  It would
be nice to listen to CDs or watch DVDs on these machines.

						-Bill

P.S.  For the sound problem, here's some info starting with the dmesg output:

      dmasound_pmac: found Keylargo rev 2 or later - H/W byte-swap disabled
      PowerMac Tumbler  DMA sound driver rev 016 installed
      Core driver edition 01.06 : PowerMac Built-in Sound driver edition 00.06

      proc/pci:

        Bus  1, device  23, function  0:
          Class ff00: Apple Computer Inc. KeyLargo Mac I/O (rev 3).
            Master Capable.  Latency=16.
            Non-prefetchable 32 bit memory at 0x80000000 [0x8007ffff].
        Bus  1, device  24, function  0:
          USB Controller: Apple Computer Inc. KeyLargo USB (rev 0).
            IRQ 27.
            Master Capable.  Latency=16.  Min Gnt=3.Max Lat=86.
            Non-prefetchable 32 bit memory at 0x80081000 [0x80081fff].
        Bus  1, device  25, function  0:
          USB Controller: Apple Computer Inc. KeyLargo USB (#2) (rev 0).
            IRQ 28.
            Master Capable.  Latency=16.  Min Gnt=3.Max Lat=86.
            Non-prefetchable 32 bit memory at 0x80080000 [0x80080fff].

      /dev/sndstat:

      PowerMac Tumbler DMA sound driver rev 016 :
      Core driver edition 01.06 : PowerMac Built-in Sound driver edition 00.06
      HW rates: 48000 44100 s/sec
      HW AFMTS: signed 16 bit BE
                       === Formats & settings ===
      Parameter                 soft                hard
      Format   :    signed 16 bit BE    signed 16 bit BE
      Samp Rate:         22050 s/sec         44100 s/sec
      Channels :              stereo              stereo
                       === Sound Queue status ===
      Allocated: Buffers  Size
          write:       4 32768
      Current  : MaxFrg FragSiz MaxAct Frnt Rear Cnt RrSize A B S L  xruns
          write:      4   32768      4    0   -1   0      0 0 0 0 0      0

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

First, thanks to BenH for his fix in the 2.4.19-pre8-ben0 kernel that
once again allows booting of the 867 MHz G4.  Unfortunately, I now have
a new problem as the acenic driver is now broken (using a NetGear GA620
NIC).  The previously working version was from a 2.4.17-pre2-ben0 kernel.
I can send a diff between the two sources if that would be of any help.

Also, is there any update on why sound doesn't work on the 867?  It would
be nice to listen to CDs or watch DVDs on these machines.

Yes, send the diff please, and CC the driver maintainer.

For sound, what makes you think is doesn't work ? (it should actually).

Did you try tweaking the volume with a mixer like gmix or so ?

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Unfortunately, I now have
a new problem as the acenic driver is now broken (using a NetGear GA620
NIC).  The previously working version was from a 2.4.17-pre2-ben0 kernel.
I can send a diff between the two sources if that would be of any help.

Does this patch help?

Jes could you please send this patch on to Marcelo/Linus, they want your
OK before taking it.

Anton

diff -urN linux-2.5/drivers/net/acenic.c linux-2.5_work/drivers/net/acenic.c

--- linux-2.5/drivers/net/acenic.c	Thu Apr  4 23:19:50 2002
+++ linux-2.5_work/drivers/net/acenic.c	Tue Apr  9 14:44:56 2002

@@ -2692,7 +2692,7 @@
 	flagsize &= ~BD_FLG_COAL_NOW;
 #endif

-	if (!ACE_IS_TIGON_I(ap)) {
+	if (ACE_IS_TIGON_I(ap)) {
 		writel(addr >> 32, &desc->addr.addrhi);
 		writel(addr & 0xffffffff, &desc->addr.addrlo);
 		writel(flagsize, &desc->flagsize);

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

quoted

quoted

quoted

quoted

"Anton" == Anton Blanchard [off-list ref] writes:

quoted

Unfortunately, I now have a new problem as the acenic driver is now
broken (using a NetGear GA620 NIC).  The previously working version
was from a 2.4.17-pre2-ben0 kernel.  I can send a diff between the
two sources if that would be of any help.

Anton> Does this patch help?

Anton> Jes could you please send this patch on to Marcelo/Linus, they
Anton> want your OK before taking it.

Sure will do. Sorry about the delay, I went off to Europe for 10 days.

Jes

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Yep, that fixed it!!!  Thanks a bunch.

			-Bill



On Fri, 10 May 2002, Anton Blanchard wrote:

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/