Hello
The attached patch fixes the following issues:
- arch/ppc/kernel/Makefile
ppc4xx_pm.o missing in export-objs list
- arch/ppc/kernel/ppc4xx_pm.c
missing include file + missing #ifdef #endif
- arch/ppc/kernel/ppc4xx_pic.c
fixed constant in ppc405_pic_get_irq()
(NR_IRQS is not necessarily the total number of UIC irqs)
- arch/ppc/platforms/ibm_ocp.h
wrong header file included + some little name fixes
Regarding the newly introduce support for cascaded UICs:
Isn't the CONFIG_CASCADING_UIC option redundant?
If (CONFIG_CASCADING_UIC == (NR_UICS > 1)) is true, CONFIG_CASCADING_UIC
could be replace by (NR_UICS > 1).
Dave
David Müller (ELSOFT AG) wrote:
Hello
The attached patch fixes the following issues:
- arch/ppc/kernel/Makefile
ppc4xx_pm.o missing in export-objs list
- arch/ppc/kernel/ppc4xx_pm.c
missing include file + missing #ifdef #endif
ok.
- arch/ppc/kernel/ppc4xx_pic.c
fixed constant in ppc405_pic_get_irq()
(NR_IRQS is not necessarily the total number of UIC irqs)a
hmmmmm... we should get ride of "NR_BOARD_IRQS" instead?
- arch/ppc/platforms/ibm_ocp.h
wrong header file included + some little name fixes
header file fix all ready in. I will get the name change next patch in.
Regarding the newly introduce support for cascaded UICs:
Isn't the CONFIG_CASCADING_UIC option redundant?
If (CONFIG_CASCADING_UIC == (NR_UICS > 1)) is true, CONFIG_CASCADING_UIC
could be replace by (NR_UICS > 1).
Good point:)
Dave
Armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Hi
Armin wrote:
David Müller (ELSOFT AG) wrote:
quoted
Hello
- arch/ppc/kernel/ppc4xx_pic.c
fixed constant in ppc405_pic_get_irq()
(NR_IRQS is not necessarily the total number of UIC irqs)a
hmmmmm... we should get ride of "NR_BOARD_IRQS" instead?
What do you mean by "get ride of "NR_BOARD_IRQS"".
Remove "NR_BOARD_IRQS" and the whole functionality behind of it
completely or just replace "NR_BOARD_IRQS" by a more meaningful name?
Dave
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/