[PATCH] Various patches against linuxppc_dev-2.4.14-pre7

STALE9092d

4 messages, 3 authors, 2001-11-05 · open the first message on its own page

[PATCH] Various patches against linuxppc_dev-2.4.14-pre7

From: David Müller (ELSOFT AG) <hidden>
Date: 2001-11-02 15:49:57

Hello

The attached patch fixes the following issues:

   - include/asm-ppc/ibm4xx.h
      missing include file  (I'm not sure if this is the correct fix)

   - drivers/net/ppc405_enet.h
      missing include file  (ditto)

   - arch/ppc/kernel/ppc4xx_setup.c
      added call to board_setup_irq() in ppc4xx_init_IRQ()
      added call to board_setup_rtc_access() in platform_init()

   - arch/ppc/kernel/walnut.c
   - arch/ppc/kernel/redwood.c
   - arch/ppc/kernel/cpci405.c
   - arch/ppc/kernel/ep405.c
      added necessary board_setup_irq() and
      board_setup_rtc_access() functions



Dave

Re: [PATCH] Various patches against linuxppc_dev-2.4.14-pre7

From: Tom Rini <hidden>
Date: 2001-11-02 16:20:32

On Fri, Nov 02, 2001 at 04:49:57PM +0100, David M?ller (ELSOFT AG) wrote:
  - include/asm-ppc/ibm4xx.h
     missing include file  (I'm not sure if this is the correct fix)

  - drivers/net/ppc405_enet.h
     missing include file  (ditto)
What's broken right now?  <asm/ibm405gp.h> gets included by CONFIG_FOO,
if FOO is a 405GP board.

  - arch/ppc/kernel/ppc4xx_setup.c
     added call to board_setup_irq() in ppc4xx_init_IRQ()
     added call to board_setup_rtc_access() in platform_init()

  - arch/ppc/kernel/walnut.c
  - arch/ppc/kernel/redwood.c
  - arch/ppc/kernel/cpci405.c
  - arch/ppc/kernel/ep405.c
     added necessary board_setup_irq() and
     board_setup_rtc_access() functions
Shouldn't board_setup_rtc_access() do all of the RTC stuff, not just
changing the nvram bits?  If your board needs a different way to get
nvram access, we should rename board_setup_rtc_access() to
board_setup_nvram_access()

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] Various patches against linuxppc_dev-2.4.14-pre7

From: David Müller (ELSOFT AG) <hidden>
Date: 2001-11-03 08:19:51

Tom Rini wrote:
On Fri, Nov 02, 2001 at 04:49:57PM +0100, David M?ller (ELSOFT AG) wrote:

quoted
 - include/asm-ppc/ibm4xx.h
    missing include file  (I'm not sure if this is the correct fix)

 - drivers/net/ppc405_enet.h
    missing include file  (ditto)
What's broken right now?  <asm/ibm405gp.h> gets included by CONFIG_FOO,
if FOO is a 405GP board.

Sorry, my fault. I was a little bit too fast. ;-)


quoted
 - arch/ppc/kernel/ppc4xx_setup.c
    added call to board_setup_irq() in ppc4xx_init_IRQ()
    added call to board_setup_rtc_access() in platform_init()

 - arch/ppc/kernel/walnut.c
 - arch/ppc/kernel/redwood.c
 - arch/ppc/kernel/cpci405.c
 - arch/ppc/kernel/ep405.c
    added necessary board_setup_irq() and
    board_setup_rtc_access() functions
Shouldn't board_setup_rtc_access() do all of the RTC stuff, not just
changing the nvram bits?  If your board needs a different way to get
nvram access, we should rename board_setup_rtc_access() to
board_setup_nvram_access()
See attached patch


Dave

Re: [PATCH] Various patches against linuxppc_dev-2.4.14-pre7

From: Dan Malek <hidden>
Date: 2001-11-05 17:05:41

Tom Rini wrote:

Shouldn't board_setup_rtc_access() do all of the RTC stuff,
Please try to coordinate your RTC stuff with Armin.  I don't have
enough knowledge of the details to discuss this, and it appears there
is a very standard way of working with the RTC, which is board
specific.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help