Re: Adding 'bus_offset' to pci_controller

"Mark A. Greer" wrote:

Paul Mackerras wrote:

quoted

For now something like what you have suggested should be OK except
that I would note that you could use the host->first_busno field,
which already exists, instead of adding a new field.

Oh man, DUH...

Thanks Paul, I'll make the change & push it in.

Wait, I can't b/c then *everyone* will have this subtraction happen and
everyone but me would be broken.
With a separate field, I don't mess up other  board ports.

Another way to go would be to #ifdef your suggestion into indirect_pci.c
for my board only.
Which do you prefer?

Mark


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Mark A. Greer writes:

Wait, I can't b/c then *everyone* will have this subtraction happen and
everyone but me would be broken.
With a separate field, I don't mess up other  board ports.

Well, how many other boards are there out there that use
indirect_pci.c and have more than one host bridge?  Anyone?

Another way to go would be to #ifdef your suggestion into indirect_pci.c
for my board only.
Which do you prefer?

Not the ifdef. :)  Either make your own version of the indirect_pci
routines or add the field.

Paul.

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/