Hey all. I notice paul made ppc_htab.c compile on all arches again. I'm
not about to undo this or anything, but I still don't agree with it. It
does _not_ do anything when running on !6xx, more more specifically
!CPU_FTR_L2CR. We -EFAULT on this case before we do anything. I _think_
but I'm not totally sure that the bits which were printed out before, in the
stock code are bogus. I also think that if we are going to put in other,
useful infos on all procs, we should put it in another file (src and /proc).
Just my 2 cents.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Tom Rini wrote:
Hey all. I notice paul made ppc_htab.c compile on all arches again. I'm
not about to undo this or anything, but I still don't agree with it.
Just look at it carefully. In the past, on processors without HPTE
the code was almost one big no-op (due to conditional tests, etc.) but
somewhere there were a few sublte generic operations (like tlbie) that
were important to (nearly) all processors. I often took advantage of
that. The code would compile, no #ifdef necessary, generic functions
called, and in the end "the right thing" would happen :-).
-- Dan
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
On Mon, Aug 27, 2001 at 02:19:18PM -0400, Dan Malek wrote:
Tom Rini wrote:
quoted
Hey all. I notice paul made ppc_htab.c compile on all arches again. I'm
not about to undo this or anything, but I still don't agree with it.
Just look at it carefully.
Okay.
In the past, on processors without HPTE
the code was almost one big no-op (due to conditional tests, etc.) but
somewhere there were a few sublte generic operations (like tlbie) that
were important to (nearly) all processors. I often took advantage of
that. The code would compile, no #ifdef necessary, generic functions
called, and in the end "the right thing" would happen :-).
Yes, but that doesn't happen now, is what I'm trying to get it. We -EFAULT
before then. If I'm reading the current code right, it appears to now all
be HPTE related anyhow. I think it'd be a great thing to put the generic
stuffs into a 'generic' file. I think putting more things into
/proc/ppc_htab, when it used to print anything on !6xx, was a laziness
induced idea. It worked but was ugly. :) We can't do that anymore,
w/o hacking up the code abit. It does compile now, w/ less ifdefs than before
since we tossed in more dummy #defines. I just don't get why we want to
compile it when it doesn't do anything...
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/