2.4 sleep power consumption patch; final buttons patch

4 messages, 2 authors, 2001-08-17 · open the first message on its own page

2.4 sleep power consumption patch; final buttons patch

From: Joseph P. Garcia <hidden>
Date: 2001-08-16 09:00:22

Attached is a patch that addresses sleep-time fan activation on wallstreets, and probably other pre-UMA systems.  The code existed in 2.2, and removed in 2.4 for some reason I am unaware of.  The patch is the missing 2.2 code almost verbatim.

the gist:
- mediabay IOBUS_enable/disable at sleep (not sure if its related to the fan)
- sleep notification to control power of MESH SCSI chip's host (most likely cause)

This works on my system.  This should be reviewed and merged at next convenience.  If some system crashes in sleep from it, then just don't have it map mio_base for that system.  Shouldn't affect pismo and later as they shouldn't have MESH.

Not sure about the mediabay mod tho.  It was in 2.2.  <shrug>

I wonder if Darwin forgot about MESH also..  OSX has the fan problem too.

=====

the second attachment is the volume/eject powerbook button NIL support posted a while ago, now in a final form.  Since nobody has had any negative feedback or comments, that too can be merged.  It doesn't break anything.  I promise.  Thanks to Bastien for helping out with this.

--
Joseph P. Garcia
http://www.lycestra.com/

Re: 2.4 sleep power consumption patch; final buttons patch

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2001-08-16 09:43:24

Attached is a patch that addresses sleep-time fan activation on
wallstreets, and probably other pre-UMA systems.  The code existed in
2.2, and removed in 2.4 for some reason I am unaware of.  The patch is
the missing 2.2 code almost verbatim.
Thanks !
the gist:
- mediabay IOBUS_enable/disable at sleep (not sure if its related to the fan)
That one should be now done in feature.c, no need to duplicate the code
in mediabay.c (in fact, doing it twice may even be a problem).
- sleep notification to control power of MESH SCSI chip's host (most
likely cause)
Ok, that's interesting, it probably got "lost" when I merged all of the
sleep stuff to 2.4, and since I no longer have a MESH-based box ...
This works on my system.  This should be reviewed and merged at next
convenience.  If some system crashes in sleep from it, then just don't
have it map mio_base for that system.  Shouldn't affect pismo and later
as they shouldn't have MESH.

Not sure about the mediabay mod tho.  It was in 2.2.  <shrug>

I wonder if Darwin forgot about MESH also..  OSX has the fan problem too.
Darwin has a weird MESH driver, dunno if it changed much since the last time
I looked at it (at that time, it didn't work properly on wallstreet).

I'll take card of merging those.
=====

the second attachment is the volume/eject powerbook button NIL support
posted a while ago, now in a final form.  Since nobody has had any
negative feedback or comments, that too can be merged.  It doesn't break
anything.  I promise.  Thanks to Bastien for helping out with this.
Ok, Will be in asap.

Thanks !

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4 sleep power consumption patch; final buttons patch

From: Joseph P. Garcia <hidden>
Date: 2001-08-16 16:23:51

On Thu, 16 Aug 2001 11:43:24 +0200
Benjamin Herrenschmidt [off-list ref] wrote:
quoted
- mediabay IOBUS_enable/disable at sleep (not sure if its related to the fan)
That one should be now done in feature.c, no need to duplicate the code
in mediabay.c (in fact, doing it twice may even be a problem).
I just tested without the mediabay patch segment on my system, and the fan issue returned.  feature.c doesn't seem to be handling this properly at the moment.


Thanks!

--
Joseph P. Garcia
http://www.lycestra.com/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4 sleep power consumption patch; final buttons patch

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2001-08-17 20:19:21

quoted
That one should be now done in feature.c, no need to duplicate the code
in mediabay.c (in fact, doing it twice may even be a problem).
I just tested without the mediabay patch segment on my system, and the
fan issue returned.  feature.c doesn't seem to be handling this properly
at the moment.
The code in feature.c appear to have been broken for the wallstreet
when I split the wallstreet features from desktop heathrow features.

I'll push a fix tonight.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help