Re: problem in kernel-2.4.6.pre6

On Sat, Jun 30, 2001 at 09:21:51AM +0900, Kaoru Fukui wrote:

Hi!

I have had compilation problem in kernel-2.4.6.pre6-devel also standard.
The error is

usb-ohci.c: Infunction 'ohci_sleep_notify'
usb-ohci.c:2752 too few argments to function 'ohci_pci_supend'


ochi_pci_suspend (strct pci_dev *dev, u32 state){
<snip>
}

static int ohci_sleep_notify(struct pmu_sleep_notifier * self, int when){
<snip>
                  case PBOOK_SLEEP_NOW:
                       ohci_pci_suspend(ohci->ohci_dev); <--- it's worng
<snip>

}

please see the attached "fix". As the u32 state argument is nowhere used in
ohci_pci_suspend, I think it's save to remove it.

Kaoru

--
Live long and prosper
- Harald Welte / laforge@gnumonks.org               http://www.gnumonks.org/

please see the attached "fix". As the u32 state argument is nowhere used in
ohci_pci_suspend, I think it's save to remove it.

wrong way. ohci_pci_suspend() is called by the generic PM code with this
argument, so it's must not be removed. The fix is to pass "3" as an
argument, or use the upated usb-ohci driver in my rsync tree. I'll
submit those patches to the ohci maintainer soon.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/