[PATCH v2 0/1] wcn36xx: Revert firmware link monitoring

STALE1786d

Revision v2 of 3 in this series.

3 messages, 2 authors, 2021-10-25 · open the first message on its own page

[PATCH v2 0/1] wcn36xx: Revert firmware link monitoring

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2021-10-23 09:31:01

V2:
- Adds Fixes tag

V1:
We can get this working with

- Secure APs PS on/off
- Open APs PS on

by setting firmware feature bit WLANACTIVE_OFFLOAD 

Open APs PS off though is non-functional even with the above bit enabled
and three quaters of a wheel is useless.

So unfortunately for now zap it off.

Bryan O'Donoghue (1):
  Revert "wcn36xx: Enable firmware link monitoring"

 drivers/net/wireless/ath/wcn36xx/main.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.33.0

[PATCH v2 1/1] Revert "wcn36xx: Enable firmware link monitoring"

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2021-10-23 09:31:09

This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.

Fixes: c973fdad79f6 ("wcn36xx: Enable firmware link monitoring")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Benjamin Li <redacted>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index dd8810fd76a3d..fd8b2753da7dd 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
 	ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL);
 	ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS);
 	ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS);
-	ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR);
 
 	wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
 		BIT(NL80211_IFTYPE_AP) |
-- 
2.33.0

Re: [PATCH v2 1/1] Revert "wcn36xx: Enable firmware link monitoring"

From: Kalle Valo <hidden>
Date: 2021-10-25 08:58:58

Bryan O'Donoghue [off-list ref] writes:
This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.

Fixes: c973fdad79f6 ("wcn36xx: Enable firmware link monitoring")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Benjamin Li <redacted>
Sorry, I missed you had sent v2 already. But please do check my comments
from v1.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help