[PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

Subsystems: realtek wireless driver (rtw89), the rest

STALE1801d LANDED

Landed in mainline as c6477cb23704 on 2021-10-27.

3 messages, 3 authors, 2021-10-27 · open the first message on its own page

[PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

From: Kevin Lo <hidden>
Date: 2021-10-21 06:32:34 

It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
it should return -EFAULT rather than 0.  Otherwise, the function doesn't need 
to exist.

Signed-off-by: Kevin Lo <redacted>
---
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 69384c43c046..afcd07ab1de7 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
 	const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;
 
 	if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
-		return 0;
+		return -EFAULT;
 
 	return 0;
 }

RE: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

From: Pkshih <pkshih@realtek.com>
Date: 2021-10-22 00:26:36 

-----Original Message-----
From: Kevin Lo <redacted>
Sent: Thursday, October 21, 2021 2:32 PM
To: linux-wireless@vger.kernel.org
Cc: Pkshih <pkshih@realtek.com>
Subject: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
it should return -EFAULT rather than 0.  Otherwise, the function doesn't need
to exist.

Signed-off-by: Kevin Lo <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

quoted hunk
---
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 69384c43c046..afcd07ab1de7 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
 	const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;

 	if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
-		return 0;
+		return -EFAULT;
Fortunately, current checking is always equal, so it doesn't affect the result.

 	return 0;
 }

--
Ping-Ke






  

    
Re: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

    

      From: Kalle Valo <hidden>

      Date: 2021-10-27 07:37:29 
    

  

  
Kevin Lo [off-list ref] wrote:

quoted hunk
It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
it should return -EFAULT rather than 0.  Otherwise, the function doesn't need 
to exist.

Signed-off-by: Kevin Lo <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 69384c43c046..afcd07ab1de7 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
 	const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;
 
 	if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
-		return 0;
+		return -EFAULT;
 
 	return 0;
 }
Patch applied to wireless-drivers-next.git, thanks.

c6477cb23704 rtw89: fix return value in hfc_pub_cfg_chk

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YXEJey8lKksAZif4@ns.kevlo.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches





    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help