RE: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
From: Pkshih <pkshih@realtek.com>
Date: 2021-10-18 01:31:15
Also in:
kernel-janitors, lkml, netdev
-----Original Message-----
From: Colin King <redacted>
Sent: Friday, October 15, 2021 11:21 PM
To: Kalle Valo <redacted>; David S . Miller <davem@davemloft.net>; Jakub Kicinski
[off-list ref]; Pkshih [off-list ref]; linux-wireless@vger.kernel.org;
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
From: Colin Ian King <redacted>
The function rtw89_mac_enable_bb_rf is a void return type, so there is
no return error code to ret, so the following check for an error in ret
is redundant dead code and can be removed.
Addresses-Coverity: ("Logically dead code")
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Colin Ian King <redacted>Acked-by: Ping-Ke Shih <pkshih@realtek.com>
quoted hunk ↗ jump to hunk
--- drivers/net/wireless/realtek/rtw89/mac.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/wireless/realtek/rtw89/mac.cb/drivers/net/wireless/realtek/rtw89/mac.c index 0171a5a7b1de..69384c43c046 100644--- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c@@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev) goto fail; rtw89_mac_enable_bb_rf(rtwdev); - if (ret) - goto fail; ret = rtw89_mac_sys_init(rtwdev); if (ret) --2.32.0 ------Please consider the environment before printing this e-mail.