[PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx

Subsystems: realtek wireless driver (rtw88), the rest

STALE1837d

2 messages, 2 authors, 2021-08-22 · open the first message on its own page

[PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx

From: Larry Finger <hidden>
Date: 2021-08-21 21:05:15

From: Ugo Rémery <redacted>

    8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
    to disable pci ASPM capability.

Signed-off-by: Larry Finger <redacted>
---
v2 - add s-o-b line
---
 drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index e7d17ab8f113..31ee859d379b 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1701,6 +1701,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
 		},
 		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
 	},
+	{
+		.callback = disable_pci_caps,
+		.ident = "HP HP Pavilion Laptop 14-ce0xxx",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Laptop 14-ce0xxx"),
+		},
+		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
+	},
 	{}
 };
 
-- 
2.32.0

Re: [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx

From: Kalle Valo <hidden>
Date: 2021-08-22 05:07:43

Larry Finger [off-list ref] writes:
From: Ugo Rémery <redacted>

    8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
    to disable pci ASPM capability.

Signed-off-by: Larry Finger <redacted>
If Ugo wrote this (which I assume he did as he is marked as the author
in the from line) his s-o-b is also needed. The order of s-o-b should be
first the author's (Ugo) and then the submitter's (Larry).

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help