[PATCH v2] mt76: mt7921: enable VO tx aggregation

Subsystems: mediatek mt76 wireless lan driver, the rest

STALE1828d

2 messages, 2 authors, 2021-08-04 · open the first message on its own page

[PATCH v2] mt76: mt7921: enable VO tx aggregation

From: YN Chen <hidden>
Date: 2021-08-04 10:31:59 

From: Deren Wu <redacted>

Avoid throughput drop in VO streaming, enable TX BA by default.

Signed-off-by: Deren Wu <redacted>
Signed-off-by: YN Chen <redacted>
---
v1 -> v2 : commit format adjustment
---
 drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
index 296e0f7a1d14..1be1e07ae786 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
@@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi)
 		return;
 
 	tid = FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1]));
-	if (tid >= 6) /* skip VO queue */
-		return;
 
 	val = le32_to_cpu(txwi[2]);
 	fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 |
-- 
2.25.1

Re: [PATCH v2] mt76: mt7921: enable VO tx aggregation

From: Lorenzo Bianconi <lorenzo@kernel.org>
Date: 2021-08-04 16:21:49 

From: Deren Wu <redacted>

Avoid throughput drop in VO streaming, enable TX BA by default.
802.11 ampdu is disabled for VO traffic in order to avoid introducing delay I guess.

Regards,
Lorenzo
quoted hunk
Signed-off-by: Deren Wu <redacted>
Signed-off-by: YN Chen <redacted>
---
v1 -> v2 : commit format adjustment
---
 drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
index 296e0f7a1d14..1be1e07ae786 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
@@ -913,8 +913,6 @@ mt7921_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi)
 		return;
 
 	tid = FIELD_GET(MT_TXD1_TID, le32_to_cpu(txwi[1]));
-	if (tid >= 6) /* skip VO queue */
-		return;
 
 	val = le32_to_cpu(txwi[2]);
 	fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 |
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help