[PATCH linux-next] include:ssb: fix boolreturn.cocci warnings

Subsystems: sonics silicon backplane driver (ssb), the rest

STALE1830d LANDED

Landed in mainline as 8d4be124062b on 2021-08-29.

2 messages, 2 authors, 2021-08-29 · open the first message on its own page

[PATCH linux-next] include:ssb: fix boolreturn.cocci warnings

From: CGEL <hidden>
Date: 2021-08-24 06:13:52

From: Jing Yangyang <redacted>

./include/linux/ssb/ssb_driver_extif.h:200:8-9:WARNING: return of 0/1 in
function 'ssb_extif_available' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Reported-by: Zeal Robot <redacted>
Signed-off-by: Jing Yangyang <redacted>
---
 include/linux/ssb/ssb_driver_extif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ssb/ssb_driver_extif.h b/include/linux/ssb/ssb_driver_extif.h
index 3f8bc97..19253bf 100644
--- a/include/linux/ssb/ssb_driver_extif.h
+++ b/include/linux/ssb/ssb_driver_extif.h
@@ -197,7 +197,7 @@ struct ssb_extif {
 
 static inline bool ssb_extif_available(struct ssb_extif *extif)
 {
-	return 0;
+	return false;
 }
 
 static inline
-- 
1.8.3.1

Re: [linux-next] ssb: fix boolreturn.cocci warning

From: Kalle Valo <hidden>
Date: 2021-08-29 11:48:10

CGEL [off-list ref] wrote:
From: Jing Yangyang <redacted>

./include/linux/ssb/ssb_driver_extif.h:200:8-9:WARNING: return of 0/1 in
function 'ssb_extif_available' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Reported-by: Zeal Robot <redacted>
Signed-off-by: Jing Yangyang <redacted>
Patch applied to wireless-drivers-next.git, thanks.

8d4be124062b ssb: fix boolreturn.cocci warning

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210824061341.59255-1-deng.changcheng@zte.com.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help