# Re: \[PATCH v2 06/63\] cxl/core: Replace unions with struct\_group()

- From: Dan Williams \<hidden\>
- Date: 2021-08-18 22:36:38 
- List: linux-wireless
- Page: https://ratatoskr.run/linux-wireless/2021/08/1482208
- Thread: https://ratatoskr.run/linux-cxl/2021/08/1481192/t.md

```text
On Tue, Aug 17, 2021 at 11:06 PM Kees Cook [ref] wrote:
>
> Use the newly introduced struct_group_typed() macro to clean up the
> declaration of struct cxl_regs.
>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <redacted>
> Cc: Ben Widawsky <redacted>
> Cc: <redacted>
> Suggested-by: Dan Williams <redacted>

Looks good and tests ok here:

Reviewed-by: Dan Williams <redacted>
```
