[PATCH] iwlwifi: mvm: Fix missing error code in iwl_mvm_up()
From: Jiapeng Chong <hidden>
Date: 2021-07-16 10:56:36
Also in:
lkml, netdev
Subsystem:
intel wireless wifi link (iwlwifi), the rest · Maintainers:
Miri Korenblit, Linus Torvalds
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. Eliminate the follow smatch warning: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1465 iwl_mvm_up() warn: missing error code 'ret'. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 38fd588..29bab53 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c@@ -1461,8 +1461,10 @@ int iwl_mvm_up(struct iwl_mvm *mvm) while (!sband && i < NUM_NL80211_BANDS) sband = mvm->hw->wiphy->bands[i++]; - if (WARN_ON_ONCE(!sband)) + if (WARN_ON_ONCE(!sband)) { + ret = -EINVAL; goto error; + } chan = &sband->channels[0];
--
1.8.3.1