[PATCH] iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()

Subsystems: intel wireless wifi link (iwlwifi), the rest

STALE1864d LANDED

Landed in mainline as c2a3823dad49 on 2021-06-24.

3 messages, 2 authors, 2021-06-24 · open the first message on its own page

[PATCH] iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()

From: Kalle Valo <hidden>
Date: 2021-06-24 05:29:30

Stephen reported a warning:

drivers/net/wireless/intel/iwlwifi/fw/acpi.c:720:12: warning: 'iwl_acpi_eval_dsm_func' defined but not used [-Wunused-function]

The warning is correct and the function is not used anywhere, so let's
just remove it.

Reported-by: Stephen Rothwell <redacted>
Fixes: 7119f02b5d34 ("iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia")
Signed-off-by: Kalle Valo <redacted>
---
 drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 36 --------------------
 1 file changed, 36 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
index 8cf7bc3aa09a..34933f133a0a 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
@@ -717,42 +717,6 @@ int iwl_sar_geo_init(struct iwl_fw_runtime *fwrt,
 }
 IWL_EXPORT_SYMBOL(iwl_sar_geo_init);
 
-static u32 iwl_acpi_eval_dsm_func(struct device *dev, enum iwl_dsm_funcs_rev_0 eval_func)
-{
-	union acpi_object *obj;
-	u32 ret;
-
-	obj = iwl_acpi_get_dsm_object(dev, 0,
-				      eval_func, NULL,
-				      &iwl_guid);
-
-	if (IS_ERR(obj)) {
-		IWL_DEBUG_DEV_RADIO(dev,
-				    "ACPI: DSM func '%d': Got Error in obj = %ld\n",
-				    eval_func,
-				    PTR_ERR(obj));
-		return 0;
-	}
-
-	if (obj->type != ACPI_TYPE_INTEGER) {
-		IWL_DEBUG_DEV_RADIO(dev,
-				    "ACPI: DSM func '%d' did not return a valid object, type=%d\n",
-				    eval_func,
-				    obj->type);
-		ret = 0;
-		goto out;
-	}
-
-	ret = obj->integer.value;
-	IWL_DEBUG_DEV_RADIO(dev,
-			    "ACPI: DSM method evaluated: func='%d', ret=%d\n",
-			    eval_func,
-			    ret);
-out:
-	ACPI_FREE(obj);
-	return ret;
-}
-
 __le32 iwl_acpi_get_lari_config_bitmap(struct iwl_fw_runtime *fwrt)
 {
 	int ret;
-- 
2.20.1

Re: [PATCH] iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()

From: Coelho, Luciano <hidden>
Date: 2021-06-24 06:30:54

On Thu, 2021-06-24 at 08:29 +0300, Kalle Valo wrote:
Stephen reported a warning:

drivers/net/wireless/intel/iwlwifi/fw/acpi.c:720:12: warning: 'iwl_acpi_eval_dsm_func' defined but not used [-Wunused-function]

The warning is correct and the function is not used anywhere, so let's
just remove it.

Reported-by: Stephen Rothwell <redacted>
Fixes: 7119f02b5d34 ("iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia")
Signed-off-by: Kalle Valo <redacted>
Looks correct! This was a rebasing issue because I sent some patches in
this area as fixes and others for -next.

Thanks, Kalle and Stephen!

Acked-by: Luca Coelho <redacted>

--
Cheers,
Luca.

Re: [PATCH] iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()

From: Kalle Valo <hidden>
Date: 2021-06-24 16:22:38

Kalle Valo [off-list ref] wrote:
Stephen reported a warning:

drivers/net/wireless/intel/iwlwifi/fw/acpi.c:720:12: warning: 'iwl_acpi_eval_dsm_func' defined but not used [-Wunused-function]

The warning is correct and the function is not used anywhere, so let's
just remove it.

Reported-by: Stephen Rothwell <redacted>
Fixes: 7119f02b5d34 ("iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia")
Signed-off-by: Kalle Valo <redacted>
Acked-by: Luca Coelho <redacted>
Patch applied to wireless-drivers-next.git, thanks.

c2a3823dad49 iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210624052918.4946-1-kvalo@codeaurora.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help