[mac80211-next:rtnl 3/4] drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: passing argument 1 of 'wiphy_lock' from incompatible pointer type

From: kernel test robot <hidden>
Date: 2021-01-16 01:55:12
Also in: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git rtnl
head:   24431371abdbc37e228fb7041e3b6e0d7e9be359
commit: fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13 [3/4] rtnl-fixes
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13
        git remote add mac80211-next https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
        git fetch --no-tags mac80211-next rtnl
        git checkout fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c: In function 'brcmf_p2p_ifp_removed':
quoted
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: passing argument 1 of 'wiphy_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
    2444 |   wiphy_lock(&cfg->wiphy);
         |              ^~~~~~~~~~~
         |              |
         |              struct wiphy **
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:9:
   include/net/cfg80211.h:5259:45: note: expected 'struct wiphy *' but argument is of type 'struct wiphy **'
    5259 | static inline void wiphy_lock(struct wiphy *wiphy)
         |                               ~~~~~~~~~~~~~~^~~~~
quoted
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2446:16: error: passing argument 1 of 'wiphy_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
    2446 |   wiphy_unlock(&cfg->wiphy);
         |                ^~~~~~~~~~~
         |                |
         |                struct wiphy **
   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:9:
   include/net/cfg80211.h:5268:47: note: expected 'struct wiphy *' but argument is of type 'struct wiphy **'
    5268 | static inline void wiphy_unlock(struct wiphy *wiphy)
         |                                 ~~~~~~~~~~~~~~^~~~~
   cc1: some warnings being treated as errors


vim +/wiphy_lock +2444 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

  2432	
  2433	void brcmf_p2p_ifp_removed(struct brcmf_if *ifp, bool locked)
  2434	{
  2435		struct brcmf_cfg80211_info *cfg;
  2436		struct brcmf_cfg80211_vif *vif;
  2437	
  2438		brcmf_dbg(INFO, "P2P: device interface removed\n");
  2439		vif = ifp->vif;
  2440		cfg = wdev_to_cfg(&vif->wdev);
  2441		cfg->p2p.bss_idx[P2PAPI_BSSCFG_DEVICE].vif = NULL;
  2442		if (locked) {
  2443			rtnl_lock();
2444			wiphy_lock(&cfg->wiphy);
  2445			cfg80211_unregister_wdev(&vif->wdev);
2446			wiphy_unlock(&cfg->wiphy);
  2447			rtnl_unlock();
  2448		} else {
  2449			cfg80211_unregister_wdev(&vif->wdev);
  2450		}
  2451		brcmf_free_vif(vif);
  2452	}
  2453	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help