Re: [PATCH] mt76x0: build driver only as module

3 messages, 2 authors, 2018-08-03 · open the first message on its own page

Re: [PATCH] mt76x0: build driver only as module

From: Kalle Valo <hidden>
Date: 2018-08-03 09:19:31

Stanislaw Gruszka [off-list ref] writes:
There are various symbols that conflicts with mt7601u.
Due to that kernel will not build with allyesconfig.
For now limit the driver to be build only as module.

Signed-off-by: Stanislaw Gruszka <redacted>
Thanks for the quick patch!
quoted hunk
--- a/drivers/net/wireless/mediatek/mt76/Kconfig
+++ b/drivers/net/wireless/mediatek/mt76/Kconfig
@@ -11,7 +11,7 @@ config MT76x2_COMMON
 
 config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
-	depends on MAC80211
+	depends on MAC80211 && m
But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)

-- 
Kalle Valo

Re: [PATCH] mt76x0: build driver only as module

From: Stanislaw Gruszka <hidden>
Date: 2018-08-03 09:28:28

On Fri, Aug 03, 2018 at 12:19:20PM +0300, Kalle Valo wrote:
Stanislaw Gruszka [off-list ref] writes:
quoted
There are various symbols that conflicts with mt7601u.
Due to that kernel will not build with allyesconfig.
For now limit the driver to be build only as module.

Signed-off-by: Stanislaw Gruszka <redacted>
Thanks for the quick patch!
quoted
--- a/drivers/net/wireless/mediatek/mt76/Kconfig
+++ b/drivers/net/wireless/mediatek/mt76/Kconfig
@@ -11,7 +11,7 @@ config MT76x2_COMMON
 
 config MT76x0U
 	tristate "MediaTek MT76x0U (USB) support"
-	depends on MAC80211
+	depends on MAC80211 && m
But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)
Yes, rename symbols names. And I will do this, just wanted to provide
quick fix for the problem. 

Moreover seems the same thing should be done for mt7601u to avoid build
errors and perhaps with mt76 :-( 

So I'm going to rename functions.

Regards
Stanislaw 

Re: [PATCH] mt76x0: build driver only as module

From: Stanislaw Gruszka <hidden>
Date: 2018-08-03 10:09:45

On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote:
quoted
But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)
Yes, rename symbols names. And I will do this, just wanted to provide
quick fix for the problem. 

Moreover seems the same thing should be done for mt7601u to avoid build
errors and perhaps with mt76 :-( 

So I'm going to rename functions.
I have the patches, I'm building kernel with allyesconfig now,
it will take a while ...

Stanislaw
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help