[PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

Subsystems: mediatek mt76 wireless lan driver, the rest

STALE3097d

3 messages, 3 authors, 2018-04-24 · open the first message on its own page

[PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

From: Lorenzo Bianconi <hidden>
Date: 2018-04-03 20:30:25

Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
will be properly set according to the usage of an external power amplifier

Signed-off-by: Lorenzo Bianconi <redacted>
---
Changes since v1:
- remove first initialization in order to have the writes to that register
  grouped together in the same if/else chunk
---
 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
index f28c55746cea..42414c5fa01e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
@@ -257,7 +257,6 @@ mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band)
 			mt76_wr(dev, MT_TX_ALC_CFG_2, 0x1b0f0400);
 			mt76_wr(dev, MT_TX_ALC_CFG_3, 0x1b0f0476);
 		}
-		mt76_wr(dev, MT_TX_ALC_CFG_4, 0);
 
 		if (mt76x2_ext_pa_enabled(dev, band))
 			pa_mode_adj = 0x04000000;
-- 
2.16.3

Re: [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

From: Felix Fietkau <nbd@nbd.name>
Date: 2018-04-08 10:56:11

On 2018-04-03 22:30, Lorenzo Bianconi wrote:
Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
will be properly set according to the usage of an external power amplifier

Signed-off-by: Lorenzo Bianconi <redacted>
Acked-by: Felix Fietkau <nbd@nbd.name>

Re: [v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

From: Kalle Valo <hidden>
Date: 2018-04-24 17:32:02

Lorenzo Bianconi [off-list ref] wrote:
Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
will be properly set according to the usage of an external power amplifier

Signed-off-by: Lorenzo Bianconi <redacted>
Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers-next.git, thanks.

cf7b411dcea8 mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

-- 
https://patchwork.kernel.org/patch/10321735/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help