[Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code

Hi,

the commit "regulatory: add NUL to request alpha2" in linux-next-20180302 causes a regression with brcmfmac (Platform: Raspberry Pi 3 B). During driver probe i will get this error:

brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code (0x44 0x45)

But 0x44 0x45 ( = DE ) is a valid ISO3166 code.

The reason for this behavior is that the function checks the complete array, not just the first 2 elements.

IMO at least the functions brcmf_cfg80211_reg_notifier() and brcmf_translate_country_code() should be fixed.

Regards
Stefan

Hi,

Stefan Wahren [off-list ref] hat am 4. März 2018 um 18:26 geschrieben:


Hi,

the commit "regulatory: add NUL to request alpha2" in linux-next-20180302 causes a regression with brcmfmac (Platform: Raspberry Pi 3 B). During driver probe i will get this error:

brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code (0x44 0x45)

But 0x44 0x45 ( = DE ) is a valid ISO3166 code.

The reason for this behavior is that the function checks the complete array, not just the first 2 elements.

IMO at least the functions brcmf_cfg80211_reg_notifier() and brcmf_translate_country_code() should be fixed.

would it be okay to fix the regression like this [1]?

[1] - https://github.com/lategoodbye/rpi-zero/commit/5986aa583b1a8ac4dd5242b0aa489826c74fcb81

Regards
Stefan

Regards
Stefan