# Re: \[PATCH 07/26\] brcmsmac: reduce stack size with KASAN

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2017-03-06 11:31:38 
- List: linux-wireless
- Page: https://ratatoskr.run/linux-wireless/2017/03/4947199
- Thread: https://ratatoskr.run/netdev/2017/03/4945276/t.md

```text
On Mon, Mar 6, 2017 at 12:16 PM, Arnd Bergmann [ref] wrote:
> On Mon, Mar 6, 2017 at 12:02 PM, Arend Van Spriel
> [ref] wrote:
>> On 6-3-2017 11:38, Arnd Bergmann wrote:
>>> On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel
>>> [ref] wrote:

>> Given the amount of local variables maybe just tag the functions with
>> noinline instead.
>
> But that would result in less efficient object code without KASAN,
> as inlining these by default is a good idea when the stack variables
> all get folded.

Note that David Laight alread suggested renaming noinline_for_kasan
to noinline_if_stackbloat, which makes it a little more obvious what
is going on. Would that address your concern as well?

    Arnd
```
